Skip to content

Commit 87e54e7

Browse files
authored
Merge pull request #29543 from cbjeukendrup/port/4.6.0
2 parents 879de18 + c13c7b2 commit 87e54e7

File tree

1 file changed

+12
-3
lines changed

1 file changed

+12
-3
lines changed

src/notation/view/notationviewinputcontroller.cpp

Lines changed: 12 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -159,13 +159,22 @@ void NotationViewInputController::onNotationChanged()
159159
}
160160

161161
m_view->hideContextMenu();
162-
m_view->hideElementPopup();
163162

164163
const TextBase* item = notation->interaction()->editedText();
165-
if (AbstractElementPopupModel::hasTextStylePopup(item)
166-
&& (!item->isLyrics() || !item->empty())) {
164+
if (AbstractElementPopupModel::hasTextStylePopup(item)) {
165+
bool needToSeeStaffWhileEnteringText = item->isLyrics() || item->isFingering() || item->isSticking() || item->isHarmony();
166+
if (!needToSeeStaffWhileEnteringText || !item->empty()) {
167+
m_view->showElementPopup(item->type(), item->canvasBoundingRect());
168+
return;
169+
}
170+
}
171+
172+
if (item->isDynamic()) {
167173
m_view->showElementPopup(item->type(), item->canvasBoundingRect());
174+
return;
168175
}
176+
177+
m_view->hideElementPopup();
169178
});
170179

171180
currNotation->interaction()->textEditingChanged().onNotify(this, [this] {

0 commit comments

Comments
 (0)