Skip to content

[iOS] Some media item art colour extractions fail #393

@remon1496

Description

@remon1496

Context

  • Operating system and version: iOS 26.5
  • App version: TestFlight 1.0 (25)
  • Music Assistant server version: 2.8.7 Stable

Details

Problem description

The PR that closed #335 introduced fixes for the colors used for theming the player. The behaviour greatly improved on android, but on iOS not so much. Still see a lot of purple on items/examples that where discussed. Looked at the PR for this and the functionality lives in the common code.

I've atached many examples comparing iOS with Android, trent seems to be that is happens on images witha lot of black or lots of white in it (doesn't matter if its perfect white, perfect black or slightly offset).

Robot told this after I fed it the code, not saying robot is correct, but might help choosing a direction to solve this:

"The root cause is almost certainly in getBestColor. The image is ~95% black, so dominantSwatch has very low luminance and gets rejected — but then vibrantSwatch on iOS either returns null or picks something unexpected, causing the fallback to your purple theme color."

Steps to reproduce

  1. Play album 4x4=12 by deadmau5

Expected behavior

I expect (sort of) the same colors as on Android. Which are dope!

1st = iOS > 2nd = Android

Image Image

Metadata

Metadata

Assignees

No one assigned

    Labels

    bugSomething isn't workingiosiOS platform

    Type

    No type
    No fields configured for issues without a type.

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions