Skip to content

Commit 51948c1

Browse files
committed
Add note about get_ntp
1 parent b7e0e93 commit 51948c1

File tree

3 files changed

+6
-1
lines changed

3 files changed

+6
-1
lines changed

music_assistant/providers/airplay/protocols/_protocol.py

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -83,6 +83,8 @@ def running(self) -> bool:
8383
@abstractmethod
8484
async def get_ntp(self) -> int:
8585
"""Get current NTP timestamp from the CLI binary."""
86+
# this can probably be removed now that we already get the ntp
87+
# in python (within the stream session start)
8688

8789
@abstractmethod
8890
async def start(self, start_ntp: int, skip: int = 0) -> None:

music_assistant/providers/airplay/protocols/airplay2.py

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -35,7 +35,8 @@ class AirPlay2Stream(AirPlayProtocol):
3535

3636
async def get_ntp(self) -> int:
3737
"""Get current NTP timestamp."""
38-
# TODO!
38+
# this can probably be removed now that we already get the ntp
39+
# in python (within the stream session start)
3940
return get_ntp_timestamp()
4041

4142
@property

music_assistant/providers/airplay/protocols/raop.py

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -45,6 +45,8 @@ def running(self) -> bool:
4545

4646
async def get_ntp(self) -> int:
4747
"""Get current NTP timestamp from the CLI binary."""
48+
# this can probably be removed now that we already get the ntp
49+
# in python (within the stream session start)
4850
cli_binary = await get_cli_binary(self.player.protocol)
4951
# TODO: we can potentially also just generate this ourselves?
5052
self.prov.logger.debug("Getting NTP timestamp from %s CLI binary", self.player.protocol)

0 commit comments

Comments
 (0)