InjectParamsTest TCK test failure with CXF

[chkal]

The TCK verifies that parameters can be injected into resource fields and properties as required by the JAX-RS spec.

Unfortunately one of the tests fails with CXF.

[INFO] Results:
[INFO] 
[ERROR] Failures: 
[ERROR]   InjectParamsTest.injectFieldParam:119 
Expected: a string containing "Value = 'foo-bar'"
     but: was "Value = ''"
[INFO] 
[ERROR] Tests run: 5, Failures: 1, Errors: 0, Skipped: 0

This test basically verifies, that a resource field can be annotated with @QueryParam and that the value of a corresponding parameter is injected into this field.

https://github.com/mvc-spec/mvc-tck/blob/c050db27be170ff8fc7f0f41ab61e45c6b69fcc7/tests/src/main/java/org/mvcspec/tck/tests/mvc/controller/inject/InjectParamsController.java#L35-L36

I don't understand why this fails. It works fine with Glassfish and Wildfly. I don't think that this is something caused by Ozark. Perhaps CXF doesn't support injection into resources fields correctly?

It would be great if somebody could help verifying this.

[Daniel-Dos]

Hi @chkal ,

I did the test without Ozark, following the same TCK model, and it executes and displays the output when @QueryParam is used in an attribute.

with Ozark this value is Null .

test using TomEE 7.0.4 and 7.0.5

[chkal]

That's weird. I don't know why Ozark could cause this. Maybe because Ozark ships with a custom ParameterConverterProvider?

Could you perhaps debug if this method is executed and how it behaves?

https://github.com/mvc-spec/ozark/blob/master/core/src/main/java/org/mvcspec/ozark/binding/convert/MvcConverterProvider.java#L54

Perhaps you could even debug how the CXF code calling MvcConverterProvider.getConverter() handles the null returned from our implementation. From my understanding it should continue do look for other provider and finally find the default one provided by CXF.

[Daniel-Dos]

I will look too .

[Daniel-Dos]

Hi @chkal ,

I made the debug, but I could not identify the default CXF, after it passes the MVCConverterProvider.getConverter () it comes null and then the same goes to the following method of the CXF class:

Class ProviderFactory

public <T> ParamConverter<T> createParameterHandler(Class<T> paramType, 
                                                        Type genericType,
                                                        Annotation[] anns,
                                                        Message m) {
        
        anns = anns != null ? anns : new Annotation[]{};
        for (ProviderInfo<ParamConverterProvider> pi : paramConverters) {
            injectContextValues(pi, m);
            ParamConverter<T> converter = pi.getProvider().getConverter(paramType, genericType, anns);
            if (converter != null) {
                return converter;
                pi.clearThreadLocalProxies();
            }
        }
        return null;
    }

here in the case the ParamConverter <T> convert = pi.getProvider (). getConverter (paramType, genericType, anns); is null and the following is directed to the following CXF class method:

class InjectionsUtils

public static <T> T createFromParameterHandler(String value, 
                                                    Class<T> pClass,
                                                    Type genericType,
                                                    Annotation[] anns,
                                                    Message message) {
        T result = null;
        if (message != null) {
            ServerProviderFactory pf = ServerProviderFactory.getInstance(message);
            ParamConverter<T> pm = pf.createParameterHandler(pClass, genericType, anns, message);
            if (pm != null) {
                result = pm.fromString(value);
            }
        }
        return result;
    }

it can idendify the value passed by the @QueryParam, but in the end it returns null

now using @QueryParam as paramenter in the method it works normal with Ozark.

Now without Ozark, the InjectParam will work with CXF.

[chkal]

Thanks for sharing this analysis. Do you have the sample app available you used for this?

[Daniel-Dos]

Hi @chkal ,

can I do, in case you one with Ozark and another without? step a zip here or a link to some repository.

[chkal]

Awesome! A link to a repository would be great!

[Daniel-Dos]

Hi @chkal ,

follows the examples with InjectParam with and without Ozark, I did the tests with TomEE 7.0.5.

https://github.com/Daniel-Dos/InjectParamsTest-Ozark-CXF

[chkal]

Thanks @Daniel-Dos. I'll have a look, but it may take some time, as I'm on vacation for the next two weeks.

[chkal]

I experimented a bit with this issue. It is really weird. Using `@QueryParam' on a resource field doesn't work, but it is working fine if I place the annotation on the corresponding getter instead.

Also the issue is occurring even if I don't register MvcConverterProvider at all. So it looks like it has nothing to do with Ozark directly. At least this is my guess.

I just created CXF-7834 with a description of my observations. Let's see what they think about this issue.

[Daniel-Dos]

wonderful.

It really is pretty weird.

even with the response of the CXF team, could not reproduce what happened.

Now it is investigating if it is some component that Ozark uses that is generating this problem

thank you.

[chkal]

I'm not really sure what is causing this. I'm planning to setup some minimal sample environment (Tomcat + CXF + Weld) to see if I can reproduce it there. I don't think that Ozark is causing this. I removed our ParamConverterProvider and the issue still occurred. This is really weird.