all: run gopls's modernize -fix

except on internal/govendor.

Author: mvdan

format/format.go

@@ -1055,7 +1055,7 @@ func setPos(v reflect.Value, pos token.Pos) {
 		v.Set(reflect.ValueOf(pos))
 	}
 	if v.Kind() == reflect.Struct {
-		for i := 0; i < v.NumField(); i++ {
+		for i := range v.NumField() {
 			setPos(v.Field(i), pos)
 		}
 	}

format/rewrite.go

@@ -89,15 +89,15 @@ func match(m map[string]reflect.Value, pattern, val reflect.Value) bool {
 		if p.Len() != v.Len() {
 			return false
 		}
-		for i := 0; i < p.Len(); i++ {
+		for i := range p.Len() {
 			if !match(m, p.Index(i), v.Index(i)) {
 				return false
 			}
 		}
 		return true
 
 	case reflect.Struct:
-		for i := 0; i < p.NumField(); i++ {
+		for i := range p.NumField() {
 			if !match(m, p.Field(i), v.Field(i)) {
 				return false
 			}

internal.go

@@ -138,7 +138,7 @@ func format(
 	if indent == 0 && hasSpace {
 		indent = 1
 	}
-	for i := 0; i < indent; i++ {
+	for range indent {
 		res = append(res, '\t')
 	}
 

ulimit_linux_test.go

@@ -48,7 +48,7 @@ func TestWithLowOpenFileLimit(t *testing.T) {
 	)
 	t.Logf("writing %d tiny Go files", numberFilesTotal)
 	var allGoFiles []string
-	for i := 0; i < numberDirs; i++ {
+	for i := range numberDirs {
 		// Prefix "p", so the package name is a valid identifier.
 		// Add one go.mod file per directory as well,
 		// which will help catch data races when loading module info.
@@ -58,14 +58,14 @@ func TestWithLowOpenFileLimit(t *testing.T) {
 		qt.Assert(t, qt.IsNil(err))
 
 		err = os.WriteFile(filepath.Join(dirPath, "go.mod"),
-			[]byte(fmt.Sprintf("module %s\n\ngo 1.16", dirName)), 0o666)
+			fmt.Appendf(nil, "module %s\n\ngo 1.16", dirName), 0o666)
 		qt.Assert(t, qt.IsNil(err))
 
-		for j := 0; j < numberFilesPerDir; j++ {
+		for j := range numberFilesPerDir {
 			filePath := filepath.Join(dirPath, fmt.Sprintf("%03d.go", j))
 			err := os.WriteFile(filePath,
 				// Extra newlines so that "-l" prints all paths.
-				[]byte(fmt.Sprintf("package %s\n\n\n", dirName)), 0o666)
+				fmt.Appendf(nil, "package %s\n\n\n", dirName), 0o666)
 			qt.Assert(t, qt.IsNil(err))
 			allGoFiles = append(allGoFiles, filePath)
 		}