Skip to content

Commit 17147ed

Browse files
committed
Merge pull request ESCOMP#3211 from samsrabin/docs-deploy-fix
ctsm5.3.055: Remove broken FTorch submodule
1 parent fe99d70 commit 17147ed

File tree

5 files changed

+63
-4
lines changed

5 files changed

+63
-4
lines changed

.github/workflows/docs-omnibus.yml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -51,4 +51,4 @@ jobs:
5151
# TODO: Split testing.sh tests into their own steps in this job
5252
- name: Text Sphinx builds with omnibus script
5353
run: |
54-
cd doc && conda run -n ctsm_pylib ./testing.sh
54+
cd doc && ./testing.sh

.github/workflows/fleximod_test.yaml

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -22,7 +22,7 @@ jobs:
2222
uses: actions/checkout@v4
2323
- id: run-fleximod
2424
run: |
25-
$GITHUB_WORKSPACE/bin/git-fleximod update
25+
$GITHUB_WORKSPACE/bin/git-fleximod update -o
2626
echo
2727
echo "Update complete, checking status"
2828
echo
@@ -32,4 +32,4 @@ jobs:
3232
echo
3333
echo "Checking if git fleximod matches expected externals"
3434
echo
35-
git diff --exit-code
35+
git add . && git diff --exit-code && git diff --cached --exit-code

doc/ChangeLog

Lines changed: 54 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,58 @@
11
===============================================================
2+
Tag name: ctsm5.3.055
3+
Originator(s): samrabin (Sam Rabin, UCAR/TSS)
4+
Date: Thu Jun 5 13:59:20 MDT 2025
5+
One-line Summary: Remove FTorch
6+
7+
Purpose and description of changes
8+
----------------------------------
9+
10+
Incorrect CMEPS version causes a build failure.
11+
12+
13+
Significant changes to scientifically-supported configurations
14+
--------------------------------------------------------------
15+
16+
Does this tag change answers significantly for any of the following physics configurations?
17+
(Details of any changes will be given in the "Answer changes" section below.)
18+
19+
[Put an [X] in the box for any configuration with significant answer changes.]
20+
21+
[ ] clm6_0
22+
23+
[ ] clm5_0
24+
25+
[ ] ctsm5_0-nwp
26+
27+
[ ] clm4_5
28+
29+
30+
Bugs fixed
31+
----------
32+
33+
List of CTSM issues fixed (include CTSM Issue # and description):
34+
- [Issue #3210: build-and-deploy failure at ctsm5.3.053](https://github.com/ESCOMP/CTSM/issues/3210)
35+
- [Issue #3214: Build fails with FTorch checked out](https://github.com/ESCOMP/CTSM/issues/3214)
36+
37+
38+
Testing summary:
39+
----------------
40+
41+
Model now builds successfully on Izumi with all optional submodules checked out.
42+
43+
44+
Other details
45+
-------------
46+
[Remove any lines that don't apply. Remove entire section if nothing applies.]
47+
48+
List any git submodules updated (cime, rtm, mosart, cism, fates, etc.):
49+
- FTorch removed
50+
51+
Pull Requests that document the changes (include PR ids):
52+
- [Pull Request #3211: ctsm5.3.055: Remove broken FTorch submodule by samsrabin](https://github.com/ESCOMP/CTSM/pull/3211)
53+
54+
===============================================================
55+
===============================================================
256
Tag name: ctsm5.3.054
357
Originator(s): samrabin (Sam Rabin, UCAR/TSS)
458
Date: Mon Jun 2 11:39:50 MDT 2025

doc/ChangeSum

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,6 @@
11
Tag Who Date Summary
22
============================================================================================================================
3+
ctsm5.3.055 samrabin 06/05/2025 Remove FTorch
34
ctsm5.3.054 samrabin 06/02/2025 CDEPS: Allow anomaly forcings with any DATM
45
ctsm5.3.053 samrabin 05/30/2025 Fix and improve anomaly forcings for ISSP cases
56
ctsm5.3.052 erik 05/30/2025 Changes to MEGAN needed for coupled cases

doc/testing.sh

Lines changed: 5 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -2,6 +2,10 @@
22
set -e
33
set -x
44

5+
SCRIPT_DIR=$( cd -- "$( dirname -- "${BASH_SOURCE[0]}" )" &> /dev/null && pwd )
6+
cd "${SCRIPT_DIR}"
7+
8+
../bin/git-fleximod update -o
59
rm -rf _publish*
610

711
# Build all docs using container
@@ -34,7 +38,7 @@ rm -rf _build_container
3438
# Check that Makefile method works
3539
echo "~~~~~ Check that Makefile method works"
3640
rm -rf _build
37-
make SPHINXOPTS="-W --keep-going" BUILDDIR=${PWD}/_build html
41+
conda run -n ctsm_pylib make SPHINXOPTS="-W --keep-going" BUILDDIR=${PWD}/_build html
3842

3943
# Check that -b works
4044
echo "~~~~~ Check that -b works (Podman)"

0 commit comments

Comments
 (0)