Fix readiness check HTTP body leak (#1005)

mvisonneau · web-flow · commit bb21f6d66b48 · 2025-06-11T11:51:22.000+02:00
diff --git a/pkg/gitlab/client.go b/pkg/gitlab/client.go
@@ -125,6 +125,7 @@ func (c *Client) ReadinessCheck(ctx context.Context) healthcheck.Check {
 		if resp == nil {
 			return fmt.Errorf("HTTP error: empty response")
 		}
+		defer resp.Body.Close()
 
 		if err == nil && resp.StatusCode != http.StatusOK {
 			return fmt.Errorf("HTTP error: %d", resp.StatusCode)

Original file line number	Diff line number	Diff line change
`@@ -125,6 +125,7 @@ func (c *Client) ReadinessCheck(ctx context.Context) healthcheck.Check {`
`125`	`125`	`if resp == nil {`
`126`	`126`	`return fmt.Errorf("HTTP error: empty response")`
`127`	`127`	`}`
	`128`	`+ defer resp.Body.Close()`
`128`	`129`
`129`	`130`	`if err == nil && resp.StatusCode != http.StatusOK {`
`130`	`131`	`return fmt.Errorf("HTTP error: %d", resp.StatusCode)`