Merge pull request #247 from mvz/fix-rubocop-offenses

Update RuboCop configuration and fix new offenses

Author: mvz

.rubocop.yml

@@ -43,7 +43,7 @@ Metrics/ParameterLists:
   Max: 6
   MaxOptionalParameters: 4
 
-Naming/PredicateName:
+Naming/PredicatePrefix:
   AllowedMethods:
     - 'has_one'
     - 'has_many'

.rubocop_todo.yml

@@ -1,6 +1,6 @@
 # This configuration was generated by
 # `rubocop --auto-gen-config --no-offense-counts --no-auto-gen-timestamp`
-# using RuboCop version 1.63.4.
+# using RuboCop version 1.76.1.
 # The point is for the user to remove these configuration records
 # one by one as the offenses are removed from the code base.
 # Note that changes in the inspected code, or installation of new
@@ -26,7 +26,7 @@ Metrics/MethodLength:
 
 # Configuration parameters: CountComments, CountAsOne.
 Metrics/ModuleLength:
-  Max: 175
+  Max: 170
 
 # Configuration parameters: AllowedMethods, AllowedPatterns.
 Metrics/PerceivedComplexity:

lib/happymapper.rb

@@ -207,7 +207,12 @@ def collect_writable_attributes
       next if value.nil? && !attribute.options[:state_when_nil]
 
       attribute_namespace = attribute.options[:namespace]
-      ["#{attribute_namespace ? "#{attribute_namespace}:" : ""}#{attribute.tag}", value]
+      attribute_name = if attribute_namespace
+                         "#{attribute_namespace}:#{attribute.tag}"
+                       else
+                         attribute.tag.to_s
+                       end
+      [attribute_name, value]
     end
 
     attributes.to_h

nokogiri-happymapper.gemspec

@@ -35,9 +35,9 @@ Gem::Specification.new do |spec|
   spec.add_development_dependency "rake", "~> 13.0"
   spec.add_development_dependency "rake-manifest", "~> 0.2.0"
   spec.add_development_dependency "rspec", "~> 3.0"
-  spec.add_development_dependency "rubocop", "~> 1.75"
+  spec.add_development_dependency "rubocop", "~> 1.76"
   spec.add_development_dependency "rubocop-packaging", "~> 0.6.0"
   spec.add_development_dependency "rubocop-performance", "~> 1.25"
-  spec.add_development_dependency "rubocop-rspec", "~> 3.5"
+  spec.add_development_dependency "rubocop-rspec", "~> 3.6"
   spec.add_development_dependency "simplecov", "~> 0.22.0"
 end