Merge pull request #251 from mvz/root-element-namespace

Fix namespace prefix rendering on root element when specified as symbol

Author: mvz

lib/happymapper/class_methods.rb

@@ -177,7 +177,7 @@ def after_parse(&block)
     #     element.
     #
     def namespace(namespace = nil)
-      @namespace = namespace if namespace
+      @namespace = namespace.to_s if namespace
       @namespace if defined? @namespace
     end
 

spec/features/to_xml_with_namespaces_spec.rb

@@ -299,4 +299,36 @@ def initialize(parameters)
       XML
     end
   end
+
+  context "with namespace set on the root object using a symbol" do
+    let(:klass) do
+      Class.new do
+        include HappyMapper
+
+        register_namespace "prefix", "http://www.unicornland.com/prefix"
+        namespace :prefix
+        tag :foo
+        has_one :bar, String
+      end
+    end
+
+    it "renders xml that can be parsed by the same class" do
+      obj = klass.new
+      obj.bar = "foobar"
+      copy = klass.parse(obj.to_xml)
+      expect(copy.bar).to eq obj.bar
+    end
+
+    it "renders the namespace prefix on all elements" do
+      obj = klass.new
+      obj.bar = "foobar"
+
+      expect(obj.to_xml).to eq <<~XML
+        <?xml version="1.0"?>
+        <prefix:foo xmlns:prefix="http://www.unicornland.com/prefix">
+          <prefix:bar>foobar</prefix:bar>
+        </prefix:foo>
+      XML
+    end
+  end
 end

spec/happymapper/class_methods_spec.rb

@@ -14,4 +14,16 @@
       expect { klass.tag "foo:bar" }.to raise_error HappyMapper::SyntaxError
     end
   end
+
+  describe "#namespace" do
+    it "allows string values" do
+      klass.namespace "foo"
+      expect(klass.namespace).to eq "foo"
+    end
+
+    it "converts symbol values to string" do
+      klass.namespace :foo
+      expect(klass.namespace).to eq "foo"
+    end
+  end
 end