Skip to content

Commit 4010007

Browse files
dbasunagmwaykole
authored andcommitted
Update HF tests with default MC enabled, and remove skips (opendatahub-io#1009)
1 parent f43fa25 commit 4010007

File tree

5 files changed

+11
-13
lines changed

5 files changed

+11
-13
lines changed

tests/model_registry/model_catalog/constants.py

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -49,9 +49,9 @@
4949
"mixed": [
5050
"ibm-granite/granite-4.0-h-1b",
5151
"microsoft/phi-2",
52+
"microsoft/Phi-4-mini-reasoning",
53+
"microsoft/Phi-3.5-mini-instruct",
5254
"meta-llama/Llama-3.1-8B-Instruct",
53-
"RedHatAI/phi-4-quantized.w8a8",
54-
"RedHatAI/Qwen2.5-7B-Instruct",
5555
],
5656
"granite": [
5757
"ibm-granite/granite-4.0-h-small",

tests/model_registry/model_catalog/huggingface/test_huggingface_exclude_models.py

Lines changed: 9 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -9,7 +9,6 @@
99

1010
pytestmark = [
1111
pytest.mark.usefixtures("updated_dsc_component_state_scope_session", "model_registry_namespace"),
12-
pytest.mark.skip,
1312
]
1413

1514

@@ -18,10 +17,10 @@
1817
[
1918
pytest.param(
2019
{
21-
"sources_yaml": get_hf_catalog_str(ids=["mixed"], excluded_models=["RedHatAI/*", "ibm-granite/*"]),
20+
"sources_yaml": get_hf_catalog_str(ids=["mixed"], excluded_models=["meta-llama/*", "ibm-granite/*"]),
2221
},
23-
["microsoft/phi-2", "meta-llama/Llama-3.1-8B-Instruct"],
24-
["RedHatAI", "ibm-granite"],
22+
["microsoft/phi-2", "microsoft/Phi-4-mini-reasoning", "microsoft/Phi-3.5-mini-instruct"],
23+
["meta-llama", "ibm-granite"],
2524
id="test_model_exclusion_wildcard_prefix",
2625
marks=pytest.mark.install,
2726
),
@@ -40,7 +39,11 @@
4039
ids=["mixed"], excluded_models=["ibm-granite/granite-4.0-h-1b", "microsoft/phi-2"]
4140
),
4241
},
43-
["meta-llama/Llama-3.1-8B-Instruct", "RedHatAI/phi-4-quantized.w8a8", "RedHatAI/Qwen2.5-7B-Instruct"],
42+
[
43+
"meta-llama/Llama-3.1-8B-Instruct",
44+
"microsoft/Phi-4-mini-reasoning",
45+
"microsoft/Phi-3.5-mini-instruct",
46+
],
4447
["ibm-granite/granite-4.0-h-1b", "microsoft/phi-2"],
4548
id="test_model_exclusion_specific_models",
4649
marks=(pytest.mark.install, pytest.mark.xfail(reason="RHOAIENG-42506: crashes the model catalog pod")),
@@ -74,7 +77,7 @@ def test_excluded_models_not_in_catalog(
7477

7578
# Extract model names from API response
7679
catalog_model_names = [model.get("name", "") for model in response["items"]]
77-
assert set(expected_models) == set(catalog_model_names), (
80+
assert set(expected_models).issubset(set(catalog_model_names)), (
7881
f"Expected {expected_models} models to be present in response. Found {catalog_model_names}"
7982
)
8083
LOGGER.info(f"With exclusion {excluded_models}, following models were found: {catalog_model_names}")

tests/model_registry/model_catalog/huggingface/test_huggingface_model_search.py

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -8,8 +8,6 @@
88

99
LOGGER = get_logger(name=__name__)
1010

11-
pytestmark = [pytest.mark.skip]
12-
1311

1412
@pytest.mark.parametrize(
1513
"updated_catalog_config_map, hf_model_name, source_filter",

tests/model_registry/model_catalog/huggingface/test_huggingface_model_sorting.py

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -5,8 +5,6 @@
55
from tests.model_registry.model_catalog.sorting.utils import assert_model_sorting
66
from tests.model_registry.model_catalog.utils import get_hf_catalog_str
77

8-
pytestmark = [pytest.mark.skip]
9-
108

119
@pytest.mark.parametrize(
1210
"updated_catalog_config_map",

tests/model_registry/model_catalog/huggingface/test_huggingface_model_validation.py

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -15,7 +15,6 @@
1515

1616
pytestmark = [
1717
pytest.mark.usefixtures("updated_dsc_component_state_scope_session", "model_registry_namespace"),
18-
pytest.mark.skip,
1918
]
2019

2120

0 commit comments

Comments
 (0)