Remove grpc as required param in local mr resource (opendatahub-io#899)

dbasunag · mwaykole · commit a8578e7690fc · 2026-01-23T15:08:25.000+05:30
* Add workaround for RHOAIENG-40875 and remove grpc as required param in ocp resources

* updates to take our workaround
diff --git a/tests/model_registry/async_job/conftest.py b/tests/model_registry/async_job/conftest.py
@@ -25,7 +25,7 @@
 from ocp_resources.secret import Secret
 from ocp_resources.service import Service
 from ocp_resources.service_account import ServiceAccount
-from ocp_resources.model_registry_modelregistry_opendatahub_io import ModelRegistry
+from utilities.resources.model_registry_modelregistry_opendatahub_io import ModelRegistry
 from ocp_resources.config_map import ConfigMap
 from model_registry.types import RegisteredModel
 from model_registry import ModelRegistry as ModelRegistryClient
diff --git a/tests/model_registry/conftest.py b/tests/model_registry/conftest.py
@@ -25,7 +25,7 @@
 from ocp_resources.deployment import Deployment
 
 
-from ocp_resources.model_registry_modelregistry_opendatahub_io import ModelRegistry
+from utilities.resources.model_registry_modelregistry_opendatahub_io import ModelRegistry
 from ocp_resources.resource import ResourceEditor
 
 from pytest import FixtureRequest
@@ -92,7 +92,6 @@ def model_registry_instance(
         yield [mr_instance]
         mr_instance.delete(wait=True)
     else:
-        LOGGER.warning("Requested Oauth Proxy configuration:")
         db_name = param.get("db_name", "mysql")
         mr_objects = get_model_registry_objects(
             client=admin_client,
diff --git a/tests/model_registry/negative_tests/test_model_registry_creation_negative.py b/tests/model_registry/negative_tests/test_model_registry_creation_negative.py
@@ -3,7 +3,7 @@
 from simple_logger.logger import get_logger
 from ocp_resources.data_science_cluster import DataScienceCluster
 from ocp_resources.deployment import Deployment
-from ocp_resources.model_registry_modelregistry_opendatahub_io import ModelRegistry
+from utilities.resources.model_registry_modelregistry_opendatahub_io import ModelRegistry
 from pytest_testconfig import config as py_config
 from ocp_resources.namespace import Namespace
 from ocp_resources.secret import Secret
diff --git a/tests/model_registry/rbac/conftest.py b/tests/model_registry/rbac/conftest.py
@@ -7,7 +7,7 @@
 from simple_logger.logger import get_logger
 
 from ocp_resources.deployment import Deployment
-from ocp_resources.model_registry_modelregistry_opendatahub_io import ModelRegistry
+from utilities.resources.model_registry_modelregistry_opendatahub_io import ModelRegistry
 from ocp_resources.persistent_volume_claim import PersistentVolumeClaim
 from ocp_resources.secret import Secret
 from ocp_resources.service import Service
diff --git a/tests/model_registry/rbac/test_mr_rbac.py b/tests/model_registry/rbac/test_mr_rbac.py
@@ -33,7 +33,7 @@
 from mr_openapi.exceptions import ForbiddenException
 from utilities.user_utils import UserTestSession
 from kubernetes.dynamic import DynamicClient
-from ocp_resources.model_registry_modelregistry_opendatahub_io import ModelRegistry
+from utilities.resources.model_registry_modelregistry_opendatahub_io import ModelRegistry
 from tests.model_registry.utils import get_mr_service_by_label, get_endpoint_from_mr_service, get_mr_user_token
 from tests.model_registry.rbac.utils import grant_mr_access, revoke_mr_access
 from utilities.constants import Protocols
diff --git a/tests/model_registry/rest_api/conftest.py b/tests/model_registry/rest_api/conftest.py
@@ -33,7 +33,7 @@
 from ocp_resources.secret import Secret
 from ocp_resources.config_map import ConfigMap
 from simple_logger.logger import get_logger
-from ocp_resources.model_registry_modelregistry_opendatahub_io import ModelRegistry
+from utilities.resources.model_registry_modelregistry_opendatahub_io import ModelRegistry
 from pytest_testconfig import config as py_config
 from utilities.exceptions import MissingParameter
 import tempfile
@@ -158,9 +158,7 @@ def deploy_secure_mysql_and_mr(
         name=SECURE_MR_NAME,
         namespace=model_registry_namespace,
         label=get_mr_standard_labels(resource_name=SECURE_MR_NAME),
-        grpc={},
         rest={},
-        istio=None,
         oauth_proxy=OAUTH_PROXY_CONFIG_DICT,
         mysql=mysql,
         wait_for_resource=True,
diff --git a/tests/model_registry/rest_api/test_model_registry_rest_api.py b/tests/model_registry/rest_api/test_model_registry_rest_api.py
@@ -2,7 +2,7 @@
 import pytest
 from kubernetes.dynamic import DynamicClient
 from ocp_resources.deployment import Deployment
-from ocp_resources.model_registry_modelregistry_opendatahub_io import ModelRegistry
+from utilities.resources.model_registry_modelregistry_opendatahub_io import ModelRegistry
 from ocp_resources.persistent_volume_claim import PersistentVolumeClaim
 from ocp_resources.pod import Pod
 from ocp_resources.secret import Secret
diff --git a/tests/model_registry/rest_api/test_model_registry_secure_db.py b/tests/model_registry/rest_api/test_model_registry_secure_db.py
@@ -5,7 +5,7 @@
 from tests.model_registry.utils import get_mr_service_by_label, get_endpoint_from_mr_service
 from kubernetes.dynamic import DynamicClient
 from utilities.constants import Protocols
-from ocp_resources.model_registry_modelregistry_opendatahub_io import ModelRegistry
+from utilities.resources.model_registry_modelregistry_opendatahub_io import ModelRegistry
 
 from simple_logger.logger import get_logger
 
diff --git a/tests/model_registry/rest_api/test_multiple_mr.py b/tests/model_registry/rest_api/test_multiple_mr.py
@@ -3,7 +3,7 @@
 from kubernetes.dynamic import DynamicClient
 
 from ocp_resources.config_map import ConfigMap
-from ocp_resources.model_registry_modelregistry_opendatahub_io import ModelRegistry
+from utilities.resources.model_registry_modelregistry_opendatahub_io import ModelRegistry
 from ocp_resources.pod import Pod
 
 from tests.model_registry.constants import (
diff --git a/tests/model_registry/upgrade/model_registry/test_model_registry_upgrade.py b/tests/model_registry/upgrade/model_registry/test_model_registry_upgrade.py
@@ -7,7 +7,7 @@
 from tests.model_registry.constants import MODEL_NAME, MODEL_DICT
 from model_registry.types import RegisteredModel
 from model_registry import ModelRegistry as ModelRegistryClient
-from ocp_resources.model_registry_modelregistry_opendatahub_io import ModelRegistry
+from utilities.resources.model_registry_modelregistry_opendatahub_io import ModelRegistry
 from ocp_resources.custom_resource_definition import CustomResourceDefinition
 from simple_logger.logger import get_logger
 from tests.model_registry.utils import (
diff --git a/tests/model_registry/utils.py b/tests/model_registry/utils.py
@@ -12,7 +12,7 @@
 from ocp_resources.pod import Pod
 from ocp_resources.secret import Secret
 from ocp_resources.service import Service
-from ocp_resources.model_registry_modelregistry_opendatahub_io import ModelRegistry
+from utilities.resources.model_registry_modelregistry_opendatahub_io import ModelRegistry
 from kubernetes.dynamic.exceptions import ResourceNotFoundError
 from simple_logger.logger import get_logger
 from timeout_sampler import retry
@@ -565,7 +565,6 @@ def get_model_registry_objects(
                 name=name,
                 namespace=namespace,
                 label=get_mr_standard_labels(resource_name=name),
-                grpc={},
                 rest={},
                 oauth_proxy=OAUTH_PROXY_CONFIG_DICT,
                 mysql=mysql if mysql else None,
diff --git a/utilities/resources/model_registry_modelregistry_opendatahub_io.py b/utilities/resources/model_registry_modelregistry_opendatahub_io.py
@@ -0,0 +1,94 @@
+# Generated using https://github.com/RedHatQE/openshift-python-wrapper/blob/main/scripts/resource/README.md
+
+from typing import Any
+
+from ocp_resources.exceptions import MissingRequiredArgumentError
+from ocp_resources.resource import NamespacedResource
+
+
+class ModelRegistry(NamespacedResource):
+    """
+    ModelRegistry is the Schema for the modelregistries API
+    """
+
+    api_group: str = NamespacedResource.ApiGroup.MODELREGISTRY_OPENDATAHUB_IO
+
+    def __init__(
+        self,
+        downgrade_db_schema_version: int | None = None,
+        enable_database_upgrade: bool | None = None,
+        grpc: dict[str, Any] | None = None,
+        kube_rbac_proxy: dict[str, Any] | None = None,
+        mysql: dict[str, Any] | None = None,
+        oauth_proxy: dict[str, Any] | None = None,
+        postgres: dict[str, Any] | None = None,
+        rest: dict[str, Any] | None = None,
+        **kwargs: Any,
+    ) -> None:
+        r"""
+        Args:
+            downgrade_db_schema_version (int): Database downgrade schema version value. If set the database schema
+              version is downgraded to the set value during initialization
+              (Optional Parameter)
+
+            enable_database_upgrade (bool): Flag specifying database upgrade option. If set to true, it enables
+              database migration during initialization (Optional parameter)
+
+            grpc (dict[str, Any]): Deprecated: Configuration for gRPC endpoint is deprecated and will be
+              removed in a future release
+
+            kube_rbac_proxy (dict[str, Any]): kube-rbac-proxy configuration options
+
+            mysql (dict[str, Any]): MySQL configuration options
+
+            oauth_proxy (dict[str, Any]): OpenShift OAuth proxy configuration options
+
+            postgres (dict[str, Any]): PostgreSQL configuration options
+
+            rest (dict[str, Any]): Configuration for REST endpoint
+
+        """
+        super().__init__(**kwargs)
+
+        self.downgrade_db_schema_version = downgrade_db_schema_version
+        self.enable_database_upgrade = enable_database_upgrade
+        self.grpc = grpc
+        self.kube_rbac_proxy = kube_rbac_proxy
+        self.mysql = mysql
+        self.oauth_proxy = oauth_proxy
+        self.postgres = postgres
+        self.rest = rest
+
+    def to_dict(self) -> None:
+
+        super().to_dict()
+
+        if not self.kind_dict and not self.yaml_file:
+            if self.rest is None:
+                raise MissingRequiredArgumentError(argument="self.rest")
+
+            self.res["spec"] = {}
+            _spec = self.res["spec"]
+
+            _spec["grpc"] = self.grpc
+            _spec["rest"] = self.rest
+
+            if self.downgrade_db_schema_version is not None:
+                _spec["downgrade_db_schema_version"] = self.downgrade_db_schema_version
+
+            if self.enable_database_upgrade is not None:
+                _spec["enable_database_upgrade"] = self.enable_database_upgrade
+
+            if self.kube_rbac_proxy is not None:
+                _spec["kubeRBACProxy"] = self.kube_rbac_proxy
+
+            if self.mysql is not None:
+                _spec["mysql"] = self.mysql
+
+            if self.oauth_proxy is not None:
+                _spec["oauthProxy"] = self.oauth_proxy
+
+            if self.postgres is not None:
+                _spec["postgres"] = self.postgres
+
+    # End of generated code
