Skip to content

Commit 1584e20

Browse files
mwileymwiley
committed
adds missing fields to trim
1 parent 8d18633 commit 1584e20

2 files changed

Lines changed: 36 additions & 2 deletions

File tree

‎lib/carquery/resources/trim.rb‎

Lines changed: 20 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -2,7 +2,11 @@ module Carquery
22
Trim = BaseStruct.new :id, :title, :make_code, :trim, :year, :body, :engine_position,
33
:engine_cc, :engine_cyl, :engine_type, :engine_valves_per_cyl,
44
:engine_power_ps, :engine_power_rpm, :engine_torque_nm, :engine_torque_rpm,
5-
:engine_bore_mm, :engine_stroke_mm, :engine_compression, :engine_fuel,
5+
:engine_bore_mm, :engine_stroke_mm, :engine_compression, :model_engine_l,
6+
:model_engine_ci, :model_engine_bore_in, :model_engine_stroke_in, :model_engine_valves,
7+
:model_engine_power_hp, :model_engine_power_kw, :model_engine_torque_lbft,
8+
:model_engine_torque_kgm, :model_top_speed_mph, :model_weight_lbs, :model_length_in,
9+
:model_width_in, :model_height_in, :model_wheelbase_in, :engine_fuel,
610
:top_speed_kph, :speedup_0_to_100_kph, :drive, :transmission_type,
711
:seats, :doors, :weight_kg, :length_mm, :width_mm, :height_mm,
812
:wheelbase_mm, :lkm_hwy, :lkm_mixed, :lkm_city, :fuel_cap_l,
@@ -28,6 +32,21 @@ def self.build raw
2832
get_f( raw["model_engine_bore_mm"] ),
2933
get_f( raw["model_engine_stroke_mm"] ),
3034
get_f( raw["model_engine_compression"] ),
35+
get_f( raw["model_engine_l"] ),
36+
get_i( raw["model_engine_ci"] ),
37+
get_f( raw["model_engine_bore_in"] ),
38+
get_f( raw["model_engine_stroke_in"] ),
39+
get_i( raw["model_engine_valves"] ),
40+
get_i( raw["model_engine_power_hp"] ),
41+
get_i( raw["model_engine_power_kw"] ),
42+
get_i( raw["model_engine_torque_lbft"] ),
43+
get_i( raw["model_engine_torque_kgm"] ),
44+
get_f( raw["model_top_speed_mph"] ),
45+
get_i( raw["model_weight_lbs"] ),
46+
get_f( raw["model_length_in"] ),
47+
get_f( raw["model_width_in"] ),
48+
get_f( raw["model_height_in"] ),
49+
get_f( raw["model_wheelbase_in"] ),
3150
get_str( raw["model_engine_fuel"] ),
3251
get_i( raw["model_top_speed_kph"] ),
3352
get_f( raw["model_0_to_100_kph"] ),

‎spec/resources/trim_spec.rb‎

Lines changed: 16 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -6,7 +6,7 @@
66
subject { described_class.build data }
77

88
context "when valid data provided" do
9-
let(:data) { {"model_id"=>"57610", "model_make_id"=>"acura", "model_name"=>"ILX", "model_trim"=>" Hybrid", "model_year"=>"2013", "model_body"=>"Sedan", "model_engine_position"=>"Front", "model_engine_cc"=>"1500", "model_engine_cyl"=>"4", "model_engine_type"=>"in-line", "model_engine_valves_per_cyl"=>"8", "model_engine_power_ps"=>"111", "model_engine_power_rpm"=>"5500", "model_engine_torque_nm"=>"172", "model_engine_torque_rpm"=>"3500", "model_engine_bore_mm"=>"73.0", "model_engine_stroke_mm"=>"89.0", "model_engine_compression"=>"10.8", "model_engine_fuel"=>"Gasoline", "model_top_speed_kph"=>nil, "model_0_to_100_kph"=>nil, "model_drive"=>"Front", "model_transmission_type"=>"CVT ", "model_seats"=>"5", "model_doors"=>"4", "model_weight_kg"=>"1356", "model_length_mm"=>"4550", "model_width_mm"=>"1794", "model_height_mm"=>"1412", "model_wheelbase_mm"=>"2670", "model_lkm_hwy"=>"4.8", "model_lkm_mixed"=>nil, "model_fuel_cap_g"=>"13.2", "model_lkm_city"=>"5.0", "model_fuel_cap_l"=>"50", "model_mpg_hwy"=>"49", "model_mpg_city"=>"47", "model_mpg_mixed"=>nil, "model_sold_in_us"=>"1", "model_co2"=>nil, "model_make_display"=>nil, "make_display"=>"Acura", "make_country"=>"USA"} }
9+
let(:data) { {"model_id"=>"57610", "model_make_id"=>"acura", "model_name"=>"ILX", "model_trim"=>" Hybrid", "model_year"=>"2013", "model_body"=>"Sedan", "model_engine_position"=>"Front", "model_engine_cc"=>"1500", "model_engine_cyl"=>"4", "model_engine_type"=>"in-line", "model_engine_valves_per_cyl"=>"8", "model_engine_power_ps"=>"111", "model_engine_power_rpm"=>"5500", "model_engine_torque_nm"=>"172", "model_engine_torque_rpm"=>"3500", "model_engine_bore_mm"=>"73.0", "model_engine_stroke_mm"=>"89.0", "model_engine_compression"=>"10.8", "model_engine_fuel"=>"Gasoline", "model_top_speed_kph"=>nil, "model_0_to_100_kph"=>nil, "model_drive"=>"Front", "model_transmission_type"=>"CVT ", "model_seats"=>"5", "model_doors"=>"4", "model_weight_kg"=>"1356", "model_length_mm"=>"4550", "model_width_mm"=>"1794", "model_height_mm"=>"1412", "model_wheelbase_mm"=>"2670", "model_engine_l"=>"1.5", "model_engine_ci"=>"92", "model_engine_bore_in"=>"2.87", "model_engine_stroke_in"=>"3.50", "model_engine_valves"=>"32", "model_engine_power_hp"=>"109", "model_engine_power_kw"=>"82", "model_engine_torque_lbft"=>"127", "model_engine_torque_kgm"=>"18", "model_top_speed_mph"=>nil, "model_weight_lbs"=>"2989", "model_length_in"=>"179.1", "model_width_in"=>"70.6", "model_height_in"=>"55.6", "model_wheelbase_in"=>"105.1", "model_lkm_hwy"=>"4.8", "model_lkm_mixed"=>nil, "model_fuel_cap_g"=>"13.2", "model_lkm_city"=>"5.0", "model_fuel_cap_l"=>"50", "model_mpg_hwy"=>"49", "model_mpg_city"=>"47", "model_mpg_mixed"=>nil, "model_sold_in_us"=>"1", "model_co2"=>nil, "model_make_display"=>nil, "make_display"=>"Acura", "make_country"=>"USA"} }
1010

1111
it { should be_a described_class }
1212

@@ -28,6 +28,21 @@
2828
its(:engine_bore_mm) { should eq 73.0 }
2929
its(:engine_stroke_mm) { should eq 89.0 }
3030
its(:engine_compression) { should eq 10.8 }
31+
its(:model_engine_l) { should eq 1.5 }
32+
its(:model_engine_ci) { should eq 92 }
33+
its(:model_engine_bore_in) { should eq 2.87 }
34+
its(:model_engine_stroke_in){ should eq 3.5 }
35+
its(:model_engine_valves) { should eq 32 }
36+
its(:model_engine_power_hp){ should eq 109}
37+
its(:model_engine_power_kw){ should eq 82 }
38+
its(:model_engine_torque_lbft){ should eq 127 }
39+
its(:model_engine_torque_kgm){ should eq 18 }
40+
its(:model_top_speed_mph) { should be_nil }
41+
its(:model_weight_lbs) { should eq 2989 }
42+
its(:model_length_in) { should eq 179.1 }
43+
its(:model_width_in) { should eq 70.6 }
44+
its(:model_height_in) { should eq 55.6 }
45+
its(:model_wheelbase_in) { should eq 105.1 }
3146
its(:engine_fuel) { should eq "Gasoline" }
3247
its(:top_speed_kph) { should be_nil }
3348
its(:speedup_0_to_100_kph) { should be_nil }

0 commit comments

Comments
 (0)