Follow-up on failures on the offline mode in VS Code

[mwouts]

@mwouts

the problem is not solved. but i cant find too much useful info.

those tables were run and displayed properly few days before, with connected=False.
today i didnt run anything but just open the .ipynb file.

(ignore the png error)

(network error may due to my unstable network.)

Originally posted by @Norlandz in #424

[mwouts]

Hi @Norlandz, would you be able to share with me one of these problematic notebooks? You can use my email (on my github page) if you prefer. Also, v2.5.2 is now available so you might prefer to update to that version (just a fix on dependencies compared to v2.5.0)

I am surprised to see a timeout to https://unpkg.com in the logs. I don't expect any reference to that url in the offline mode (at least not from ITables). I can actually confirm that expectation with a test, see #442. If you share the notebook I'd be curious to see where this https://unpkg.com comes from.

[Norlandz]

@mwouts

I didnt save that file and made another run.
Next time it happens I will send you the file.

Sent

SHA256 hash of examine_main.ipynb:
66c06bb79da5875514c0a9e426738016c2b06d6e7ec9eb1057fe2b1cb7b765df

(PS: I almost never check my email, so its better to reply here.)

--

For code logic of setting up itables:

[mwouts]

Hi @Norlandz , thank you for sharing the notebook!

In your notebook I do see three tables displayed with ITables in the offline mode. But also, I see that there is no cell that corresponds to init_notebook_mode. You can check yourself: there is nothing like https://github.com/mwouts/itables/blob/main/src/itables/html/init_notebook_offline.html. I suspect that if you add a new cell with init_notebook_mode (from ITables in the same version) then the tables will appear correctly.

I think I see the intend with your ITablesConfig object, e.g. you want to set custom options and display the init_notebook_mode cell automatically. Re the init cell I had tried import itables.interactive, but I don't use that anymore as it does not work well with autoreload. You might well have a similar issue here.

Re sharing options between multiple notebooks you can now use the new ITables configuration file. Let me know how it works for you!

Back to your notebook, you need the itables.init_notebook_mode() in the offline mode (again, from ITables in the same version as was used to display the tables).

FYI, what v2.5 improves over v2.4 is that the table is displayed now when the library is loaded, or when the itables library is loaded, using a custom "itables ready" event. That's how the tables can now be displayed if you add the init_notebook_mode later (or if that cell is displayed after the tables). If you were to encounter other issues than a missing init_notebook_mode cell we could had logs there to distinguish between the two options.

itables/src/itables/html/datatables_template_offline.html

Lines 17 to 23 in 2383415

	if (window._itables_underscore_version) {
	init();
	} else {
	window.addEventListener("itables-version-ready", () => {
	init();
	});
	}

[Norlandz]

@mwouts

Quick update:

I suspect that if you add a new cell with init_notebook_mode (from ITables in the same version) then the tables will appear correctly.

Yep.

So there is something wrong with the way I import itabes or the %autoreload .