Skip to content

Commit bed9334

Browse files
committed
Remove mapping options
1 parent 51665f7 commit bed9334

File tree

1 file changed

+16
-34
lines changed

1 file changed

+16
-34
lines changed

Diff for: ui/src/containers/SampleListViewContainer.jsx

+16-34
Original file line numberDiff line numberDiff line change
@@ -93,31 +93,6 @@ export default function SampleListViewContainer() {
9393
displayTaskForm('AddSample');
9494
}
9595

96-
/**
97-
* Mapping between a input and a filter option value
98-
*
99-
* @param {string} id - id of input in DOM
100-
* @return {?} the value for the input
101-
*/
102-
function getFilterOptionValue(id) {
103-
let value = false;
104-
105-
const optionMap = {
106-
inQueue: filterOptions.inQueue,
107-
notInQueue: filterOptions.notInQueue,
108-
collected: filterOptions.collected,
109-
notCollected: filterOptions.notCollected,
110-
limsSamples: filterOptions.limsSamples,
111-
text: filterOptions.text,
112-
cellFilter: filterOptions.cellFilter,
113-
puckFilter: filterOptions.puckFilter,
114-
};
115-
116-
value = optionMap[id];
117-
118-
return value;
119-
}
120-
12196
function getCellFilterOptions() {
12297
let options = [];
12398

@@ -390,7 +365,14 @@ export default function SampleListViewContainer() {
390365
limsSamples: { limsSamples: e.target.checked },
391366
text: { text: e.target.value.trim() },
392367
};
393-
dispatch(filterAction(optionMap[e.target.id]));
368+
369+
let filterValue = e.target.value.trim();
370+
if (e.target.type === 'checkbox') {
371+
filterValue = e.target.checked;
372+
}
373+
debugger;
374+
375+
dispatch(filterAction([e.target.id]));
394376
if (Number(e.target.value) > 2) {
395377
window.scroll({
396378
top: 1,
@@ -669,7 +651,7 @@ export default function SampleListViewContainer() {
669651
<Col sm="6">
670652
<Form.Select
671653
id="cellFilter"
672-
value={getFilterOptionValue('cellFilter')}
654+
value={filterOptions.cellFilter}
673655
onChange={sampleGridFilter}
674656
>
675657
{getCellFilterOptions()}
@@ -688,7 +670,7 @@ export default function SampleListViewContainer() {
688670
<Col sm="6">
689671
<Form.Select
690672
id="puckFilter"
691-
value={getFilterOptionValue('puckFilter')}
673+
value={filterOptions.puckFilter}
692674
onChange={sampleGridFilter}
693675
>
694676
{getPuckFilterOptions()}
@@ -701,7 +683,7 @@ export default function SampleListViewContainer() {
701683
type="checkbox"
702684
id="inQueue"
703685
inline
704-
checked={getFilterOptionValue('inQueue')}
686+
checked={filterOptions.inQueue}
705687
onChange={sampleGridFilter}
706688
label="In Queue"
707689
/>
@@ -711,7 +693,7 @@ export default function SampleListViewContainer() {
711693
type="checkbox"
712694
inline
713695
id="notInQueue"
714-
checked={getFilterOptionValue('notInQueue')}
696+
checked={filterOptions.notInQueue}
715697
onChange={sampleGridFilter}
716698
label="Not in Queue"
717699
/>
@@ -723,7 +705,7 @@ export default function SampleListViewContainer() {
723705
type="checkbox"
724706
inline
725707
id="collected"
726-
checked={getFilterOptionValue('collected')}
708+
checked={filterOptions.collected}
727709
onChange={sampleGridFilter}
728710
label="Collected"
729711
/>
@@ -733,7 +715,7 @@ export default function SampleListViewContainer() {
733715
type="checkbox"
734716
inline
735717
id="notCollected"
736-
checked={getFilterOptionValue('notCollected')}
718+
checked={filterOptions.notCollected}
737719
onChange={() => sampleGridFilter()}
738720
label="Not Collected"
739721
/>
@@ -745,7 +727,7 @@ export default function SampleListViewContainer() {
745727
type="checkbox"
746728
inline
747729
id="limsSamples"
748-
checked={getFilterOptionValue('limsSamples')}
730+
checked={filterOptions.limsSamples}
749731
onChange={sampleGridFilter}
750732
label="LIMS Samples"
751733
/>
@@ -860,7 +842,7 @@ export default function SampleListViewContainer() {
860842
style={{ borderColor: '#CCC' }}
861843
id="text"
862844
type="text"
863-
value={getFilterOptionValue('text')}
845+
value={filterOptions.text}
864846
onChange={sampleGridFilter}
865847
/>
866848
{innerSearchIcon()}

0 commit comments

Comments
 (0)