Managing `queue` state

[dominikatrojanowska]

I found a bit buggy behavior of updating the queue state when running demo version (it works similarly at Max IV fork as well). There are two very different in state manner cases, not much different is user actions:

1st case:
This screenshot was taken after Get Samples from SC - the queue.queue state is filled in with the list of all available samples:

After mounting a sample (1.02 here) there is Next Sample button at Data Collection tab visible and the queue state remains full:

This behavior seems to be wired: the queue is filled up automatically with every sample available before queuing anything explicitly...

2nd case:
Same situation as above - getting samples from SC results in fulfilled queue

But after refreshing the page the queue is empty again:

In contrast to first scenario, after mounting a sample, queue remains empty and no Next Sample button is visible:

And this is definitely inconsistent with the 1st scenario.

Which one is correct?
Should samples appear in the queue at application start?

Tested at: https://github.com/mxcube/mxcubeweb/releases/tag/v4.561.0

[dominikatrojanowska]

1st scenario continuation:
Clicking on Next Sample button shows up this error banner: Server refused to set item enabled flag. It is raised by this api call with [null] and False as input values.
Why [null]? Well, in this case state.sampleGrid.sampleList's values do not have queueID properties.
Maybe it's worthy to provide some checking at some point?

3rd scenario - in case of explicitly queued samples:

the queueID property appears in sampleList objects:

So the Next Sample operation should be performed normally (it lasts for ever, but maybe due to the lacks in demo version)

[dominikatrojanowska]

Maybe it's worthy to provide some checking at some point?

Well, it is checked. But this cannot work properly if all the samples get form SC are automatically put to state.queue.queue. See the screenshot - queue contains all the samples available:

I can see two solutions there:

1. If samples should be enqueued when loading from SC, the queueID property is missed in state.sampleGrid.sampleList.
2. If no auto-queuing required, the value of state.queue.queue should remain [].

[marcus-oscarsson]

Not sure that I understand this entirely and that there may be more than one issue here. It may very well be a remnant from an older feature basically collecting sample by sample manually. We have never used this feature here at ESRF it was a wish from MAXIV so I can't say if its currently used or not. I think the idea was that one could simply add samples to the queue and then traverse the list of samples by clicking "Next sample" and collect manually. I think that is the behavior that one would be expected.

You are right that its strange that the queue is populated when the sample changer contents are retrieved. I don't think this should be the case. What Is a bit strange and its not entirely clear from the screenshots is that the queue store seems to be filled but the "Collect" button on the "Sample view" and "Queued Samples" (on the "Data Collection" view) does not show any "queued" samples. Perhaps thats something to look into ?