Update golangci-lint and update code to satisfy checks

Author: mm503

.github/workflows/ci.yml

@@ -51,9 +51,7 @@ jobs:
     steps:
       - uses: actions/setup-go@v5
       - uses: actions/checkout@v4
-      - uses: golangci/golangci-lint-action@v6
-        with:
-          version: v1.57.2
+      - uses: golangci/golangci-lint-action@v8
 
       - name: Go mod
         env:

.golangci.yml

@@ -1,31 +1,38 @@
+version: "2"
 linters:
   enable:
-    - structcheck
-    - varcheck
-    - staticcheck
-    - unconvert
-    - gofmt
-    - goimports
-    - golint
-    - ineffassign
-    - vet
-    - unused
-    - misspell
     - bodyclose
-    - interfacer
-    - unconvert
-    - maligned
-    # - depguard
+    - misspell
     - nakedret
     - prealloc
+    - unconvert
     - whitespace
+    - staticcheck
+    - ineffassign
+    - unused
   disable:
     - errcheck
-
+  exclusions:
+    generated: lax
+    presets:
+      - comments
+      - common-false-positives
+      - legacy
+      - std-error-handling
+    paths:
+      - bin
+      - docs
+formatters:
+  enable:
+    - gofmt
+    - goimports
+  exclusions:
+    generated: lax
+    paths:
+      - bin
+      - docs
+      - third_party$
+      - builtin$
+      - examples$
 run:
   timeout: 3m
-
-issues:
-  exclude-dirs:
-    - bin
-    - docs

pkg/db/badger.go

@@ -272,11 +272,12 @@ func (b *Badger) setObj(txn *badger.Txn, key []byte, obj interface{}, overwrite
 	if !overwrite {
 		// Overwrites are not allowed, make sure there is no object with the given key
 		_, err := txn.Get(key)
-		if err == nil {
+		switch err {
+		case nil:
 			return model.ErrAlreadyExists
-		} else if err == badger.ErrKeyNotFound {
+		case badger.ErrKeyNotFound:
 			// Key not found, do nothing
-		} else {
+		default:
 			return errors.Wrap(err, "failed to check whether key exists")
 		}
 	}

pkg/feed/xml.go

@@ -178,21 +178,22 @@ func EpisodeName(feedConfig *Config, episode *model.Episode) string {
 func EnclosureFromExtension(feedConfig *Config) itunes.EnclosureType {
 	ext := feedConfig.CustomFormat.Extension
 
-	switch {
-	case ext == "m4a":
+	switch ext {
+	case "m4a":
 		return itunes.M4A
-	case ext == "m4v":
+	case "m4v":
 		return itunes.M4V
-	case ext == "mp4":
+	case "mp4":
 		return itunes.MP4
-	case ext == "mp3":
+	case "mp3":
 		return itunes.MP3
-	case ext == "mov":
+	case "mov":
 		return itunes.MOV
-	case ext == "pdf":
+	case "pdf":
 		return itunes.PDF
-	case ext == "epub":
+	case "epub":
 		return itunes.EPUB
+	default:
+		return -1
 	}
-	return -1
 }

pkg/ytdl/ytdl.go

@@ -227,7 +227,8 @@ func (dl *YoutubeDl) exec(ctx context.Context, args ...string) (string, error) {
 func buildArgs(feedConfig *feed.Config, episode *model.Episode, outputFilePath string) []string {
 	var args []string
 
-	if feedConfig.Format == model.FormatVideo {
+	switch feedConfig.Format {
+	case model.FormatVideo:
 		// Video, mp4, high by default
 
 		format := "bestvideo[ext=mp4][vcodec^=avc1]+bestaudio[ext=m4a]/best[ext=mp4][vcodec^=avc1]/best[ext=mp4]/best"
@@ -239,15 +240,17 @@ func buildArgs(feedConfig *feed.Config, episode *model.Episode, outputFilePath s
 		}
 
 		args = append(args, "--format", format)
-	} else if feedConfig.Format == model.FormatAudio {
+
+	case model.FormatAudio:
 		// Audio, mp3, high by default
 		format := "bestaudio"
 		if feedConfig.Quality == model.QualityLow {
 			format = "worstaudio"
 		}
 
 		args = append(args, "--extract-audio", "--audio-format", "mp3", "--format", format)
-	} else {
+
+	default:
 		args = append(args, "--audio-format", feedConfig.CustomFormat.Extension, "--format", feedConfig.CustomFormat.YouTubeDLFormat)
 	}