Merge pull request #66 from mycroes/copilot/remove-try-finally-arraypool-return

Return ArrayPool buffer to pool on success only, skip return on exception

Author: mycroes

Sally7/S7Connection.cs

@@ -227,16 +227,10 @@ await stream
         public async Task ReadAsync(IDataItem[] dataItems, CancellationToken cancellationToken = default)
         {
             var results = ArrayPool<ReadWriteErrorCode>.Shared.Rent(dataItems.Length);
-            try
-            {
-                await ReadAsync(dataItems, results, cancellationToken).ConfigureAwait(false);
+            await ReadAsync(dataItems, results, cancellationToken).ConfigureAwait(false);
 
-                ReadWriteErrorHelpers.ThrowIfHasErrors("Read", dataItems, results.AsSpan(0, dataItems.Length));
-            }
-            finally
-            {
-                ArrayPool<ReadWriteErrorCode>.Shared.Return(results);
-            }
+            ReadWriteErrorHelpers.ThrowIfHasErrors("Read", dataItems, results.AsSpan(0, dataItems.Length));
+            ArrayPool<ReadWriteErrorCode>.Shared.Return(results);
         }
 
         /// <summary>
@@ -297,16 +291,10 @@ public async Task ReadAsync(IDataItem[] dataItems, Memory<ReadWriteErrorCode> re
         public async Task WriteAsync(IDataItem[] dataItems, CancellationToken cancellationToken = default)
         {
             var results = ArrayPool<ReadWriteErrorCode>.Shared.Rent(dataItems.Length);
-            try
-            {
-                await WriteAsync(dataItems, results, cancellationToken).ConfigureAwait(false);
+            await WriteAsync(dataItems, results, cancellationToken).ConfigureAwait(false);
 
-                ReadWriteErrorHelpers.ThrowIfHasErrors("Write", dataItems, results.AsSpan(0, dataItems.Length));
-            }
-            finally
-            {
-                ArrayPool<ReadWriteErrorCode>.Shared.Return(results);
-            }
+            ReadWriteErrorHelpers.ThrowIfHasErrors("Write", dataItems, results.AsSpan(0, dataItems.Length));
+            ArrayPool<ReadWriteErrorCode>.Shared.Return(results);
         }
 
         /// <summary>