Rewrite conditional, remove always-true clause

jplloyd · jplloyd · commit c2e720c73e8b · 2019-12-27T14:04:18.000+01:00
Parameter is unsigned, no need to check that it's >= 0. Closes #132
diff --git a/mypaint-brush.c b/mypaint-brush.c
@@ -1437,7 +1437,7 @@ update_brush_setting_from_json_object(MyPaintBrush *self,
 {
     MyPaintBrushSetting setting_id = mypaint_brush_setting_from_cname(setting_name);
 
-    if (!(setting_id >= 0 && setting_id < MYPAINT_BRUSH_SETTINGS_COUNT)) {
+    if (setting_id >= MYPAINT_BRUSH_SETTINGS_COUNT) {
         fprintf(stderr, "Warning: Unknown setting_id: %d for setting: %s\n",
                 setting_id, setting_name);
         return FALSE;

Original file line number	Diff line number	Diff line change
`@@ -1437,7 +1437,7 @@ update_brush_setting_from_json_object(MyPaintBrush *self,`
`1437`	`1437`	`{`
`1438`	`1438`	`MyPaintBrushSetting setting_id = mypaint_brush_setting_from_cname(setting_name);`
`1439`	`1439`
`1440`		`- if (!(setting_id >= 0 && setting_id < MYPAINT_BRUSH_SETTINGS_COUNT)) {`
	`1440`	`+ if (setting_id >= MYPAINT_BRUSH_SETTINGS_COUNT) {`
`1441`	`1441`	`fprintf(stderr, "Warning: Unknown setting_id: %d for setting: %s\n",`
`1442`	`1442`	`setting_id, setting_name);`
`1443`	`1443`	`return FALSE;`