Skip to content

Commit 18e50c9

Browse files
committed
refactor: clarify ts-expect-error comments and suppress vue lint rule
Improve the inline @ts-expect-error comments in the module and fixture config to document why the suppressions are intentional, and add eslint-disable directives for single-word component names in the nuxt-app fixtures.
1 parent 331cc8b commit 18e50c9

4 files changed

Lines changed: 5 additions & 3 deletions

File tree

fixtures/nitro-api/nuxt.config.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -16,7 +16,7 @@ export default defineNuxtConfig({
1616
users: {
1717
connector: 'pglite',
1818
},
19-
// @ts-expect-error
19+
// @ts-expect-error unknown datasource type is intentionally omitted to test validation
2020
unknownDatasource: {},
2121
},
2222
},

fixtures/nuxt-app/app/layouts/default.vue

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1,3 +1,4 @@
1+
<!-- eslint-disable vue/multi-word-component-names -->
12
<template>
23
<UApp>
34
<UMain>

fixtures/nuxt-app/app/pages/index.vue

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1,3 +1,4 @@
1+
<!-- eslint-disable vue/multi-word-component-names -->
12
<template>
23
<UContainer class="space-y-8 my-8">
34
<h1 class="text-2xl font-bold px-0.5">

src/module.ts

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -56,7 +56,7 @@ export default defineNuxtModule<ModuleOptions>({
5656

5757
Object.entries(declarations.module).forEach(([filename, contents]) => {
5858
addTypeTemplate({
59-
// @ts-expect-error
59+
// @ts-expect-error addTypeTemplate expects a string filename, but join returns a resolved path
6060
filename: join(typesDir, filename),
6161
getContents: async () => 'string' === typeof contents ? contents : await contents(),
6262
}, {
@@ -69,7 +69,7 @@ export default defineNuxtModule<ModuleOptions>({
6969
...Object.values(declarations.virtual).flatMap(modules => Object.entries(modules)),
7070
].forEach(([filename, contents]) => {
7171
addTypeTemplate({
72-
// @ts-expect-error
72+
// @ts-expect-error addTypeTemplate expects a string filename, but join returns a resolved path
7373
filename: join(typesDir, filename),
7474
getContents: async () => 'string' === typeof contents ? contents : await contents(),
7575
}, {

0 commit comments

Comments
 (0)