chore(native,libbuilder): build quiche in library-builder, consume prebuilt in mystralnative

Author: Flux159

CMakeLists.txt

@@ -851,19 +851,21 @@ endif()
 # ============================================================================
 # quiche (QUIC + HTTP/3, for the WebTransport API)
 # ============================================================================
-# quiche is a Rust library exposing a C API. We vendor the source and build a
-# static library (libquiche.a) with `cargo build --release --features ffi`.
-# download-deps.mjs clones + builds it. WebTransport is disabled (stubbed) if
-# the library is not present, so the build still succeeds without a Rust
-# toolchain.
+# quiche is a Rust library exposing a C API. The static library (libquiche.a /
+# quiche.lib + patched quiche.h, BoringSSL bundled) is built by
+# mystralengine/library-builder and downloaded as a prebuilt by
+# download-deps.mjs (like libuv/draco/swc) — the engine repo never compiles
+# Rust/BoringSSL itself. WebTransport is disabled (stubbed) if the library is
+# not present, so the build still succeeds without it.
+# Prebuilt layout: quiche/include/quiche.h, quiche/libquiche.a (or quiche.lib)
 option(MYSTRAL_USE_QUICHE "Enable QUIC/HTTP3 WebTransport via quiche" ON)
 set(QUICHE_DIR ${THIRD_PARTY_DIR}/quiche)
 if(MYSTRAL_USE_QUICHE AND EXISTS ${QUICHE_DIR} AND NOT IOS AND NOT ANDROID)
-    set(QUICHE_INCLUDE_DIR ${QUICHE_DIR}/quiche/include)
+    set(QUICHE_INCLUDE_DIR ${QUICHE_DIR}/include)
     if(WIN32)
-        set(QUICHE_LIB_PATH ${QUICHE_DIR}/target/release/quiche.lib)
+        set(QUICHE_LIB_PATH ${QUICHE_DIR}/quiche.lib)
     else()
-        set(QUICHE_LIB_PATH ${QUICHE_DIR}/target/release/libquiche.a)
+        set(QUICHE_LIB_PATH ${QUICHE_DIR}/libquiche.a)
     endif()
 
     if(EXISTS ${QUICHE_LIB_PATH} AND EXISTS ${QUICHE_INCLUDE_DIR}/quiche.h)

docs/docs/guides/webtransport.mdx

@@ -13,8 +13,10 @@ WebTransport is implemented natively on top of [Cloudflare quiche](https://githu
 
 - WebTransport is only available in builds compiled **with quiche**
   (`MYSTRAL_HAS_QUICHE`). Run `node scripts/download-deps.mjs --only quiche` to
-  fetch and build it (needs a Rust toolchain + Go + CMake for BoringSSL). If
-  quiche is not present, `new WebTransport(...)` rejects its `ready`/`closed`
+  fetch the **prebuilt** static library (built per-platform by
+  [mystralengine/library-builder](https://github.com/mystralengine/library-builder),
+  the same place Skia/libuv/Draco come from — no Rust toolchain needed locally).
+  If quiche is not present, `new WebTransport(...)` rejects its `ready`/`closed`
   promises instead of connecting.
 - The server URL must use `https://` and an explicit port, e.g.
   `https://example.com:4433/path`.
@@ -69,7 +71,7 @@ supporting `getReader().read()` and `getWriter().write()/close()/abort()`.
   WebTransport `0x41` / `0x54` signal framing.
 - WebTransport SETTINGS (`WT_MAX_SESSIONS`, etc.) are advertised via a small FFI
   shim added to quiche (`quiche_h3_config_set_additional_settings`), applied as a
-  patch during `download-deps`.
+  patch when library-builder compiles quiche (`patches/quiche-webtransport-ffi.patch`).
 
 ## Testing
 

scripts/download-deps.mjs

@@ -153,16 +153,36 @@ const DEPS = {
     extractTo: 'quickjs',
   },
   quiche: {
-    // Cloudflare quiche - QUIC + HTTP/3 (used by the WebTransport API).
-    // Built from source: git clone --recursive (BoringSSL submodule) + a small
-    // FFI patch (exposes set_additional_settings for WebTransport SETTINGS) +
-    // `cargo build --release --features ffi`. Requires a Rust toolchain, cmake,
-    // and Go (for BoringSSL). Skipped gracefully if those are missing — the C++
-    // build then compiles a WebTransport stub.
-    version: '0.24.6',
-    getUrl: () => null,  // special handling below (git clone, not an archive)
+    // Cloudflare quiche - QUIC + HTTP/3 (native backend for the WebTransport API).
+    // Prebuilt static libs (libquiche.a / quiche.lib + patched quiche.h, BoringSSL
+    // bundled) come from mystralengine/library-builder, exactly like libuv/draco/swc.
+    // The library is built there (build-quiche.py + build-quiche.yml) so the engine
+    // repo never compiles Rust/BoringSSL itself. If no prebuilt exists for this
+    // platform/arch, the C++ build compiles a WebTransport stub (MYSTRAL_HAS_QUICHE off).
+    // https://github.com/mystralengine/library-builder/releases
+    version: 'quiche-0.24.6-1',
+    getUrl: () => {
+      const baseUrl = 'https://github.com/mystralengine/library-builder/releases/download/quiche-0.24.6-1';
+      if (platformName === 'macos') {
+        const arch = ARCH === 'arm64' ? 'arm64' : 'x86_64';
+        return `${baseUrl}/quiche-mac-${arch}.zip`;
+      } else if (platformName === 'linux') {
+        if (ARCH !== 'x64') {
+          console.warn(`quiche prebuilts not available for ${platformName}-${archName}`);
+          return null;
+        }
+        return `${baseUrl}/quiche-linux-x64.zip`;
+      } else if (platformName === 'windows') {
+        if (ARCH !== 'x64') {
+          console.warn(`quiche prebuilts not available for ${platformName}-${archName}`);
+          return null;
+        }
+        return `${baseUrl}/quiche-win-x64.zip`;
+      }
+      console.warn(`quiche prebuilts not available for ${platformName}-${archName}`);
+      return null;
+    },
     extractTo: 'quiche',
-    repo: 'https://github.com/cloudflare/quiche.git',
   },
   stb: {
     // stb single-header libraries from nothings/stb
@@ -572,69 +592,6 @@ async function downloadDep(name) {
     }
   }
 
-  // Special handling for quiche (git clone --recursive + patch + cargo build)
-  if (name === 'quiche' && dep.repo) {
-    const libRel = PLATFORM === 'win32' ? 'target/release/quiche.lib' : 'target/release/libquiche.a';
-    const libPath = join(destDir, libRel);
-    if (existsSync(libPath) && !process.argv.includes('--force')) {
-      console.log(`${name} already built at ${libPath}`);
-      console.log('Skipping (use --force to rebuild)');
-      return true;
-    }
-
-    // Verify the toolchain is available; quiche needs cargo + Go (+ cmake) to
-    // build BoringSSL. If absent, skip — WebTransport compiles as a stub.
-    const haveCargo = (() => {
-      try { execSync('cargo --version', { stdio: 'ignore' }); return true; } catch { return false; }
-    })();
-    if (!haveCargo) {
-      console.warn(`Skipping ${name}: cargo (Rust toolchain) not found. WebTransport will be disabled.`);
-      return false;
-    }
-
-    try {
-      if (!existsSync(join(destDir, '.git'))) {
-        if (existsSync(destDir)) rmSync(destDir, { recursive: true });
-        console.log(`Cloning quiche ${dep.version} (with BoringSSL submodule)...`);
-        execSync(
-          `git clone --recursive --depth 1 --branch ${dep.version} ${dep.repo} "${destDir}"`,
-          { stdio: 'inherit' }
-        );
-      }
-
-      // Apply the WebTransport FFI patch (idempotent: git apply --check first).
-      const patchPath = join(__dirname, 'patches', 'quiche-webtransport-ffi.patch');
-      if (existsSync(patchPath)) {
-        const alreadyApplied = (() => {
-          try { execSync(`git -C "${destDir}" apply --reverse --check "${patchPath}"`, { stdio: 'ignore' }); return true; }
-          catch { return false; }
-        })();
-        if (!alreadyApplied) {
-          console.log('Applying quiche WebTransport FFI patch...');
-          execSync(`git -C "${destDir}" apply "${patchPath}"`, { stdio: 'inherit' });
-        } else {
-          console.log('quiche WebTransport FFI patch already applied');
-        }
-      }
-
-      console.log('Building quiche (cargo build --release --features ffi)...');
-      execSync('cargo build --release --package quiche --features ffi', {
-        cwd: destDir,
-        stdio: 'inherit',
-      });
-
-      if (existsSync(libPath)) {
-        console.log(`Successfully built ${name}: ${libPath}`);
-        return true;
-      }
-      console.error(`quiche build did not produce ${libPath}`);
-      return false;
-    } catch (error) {
-      console.error(`Failed to build ${name}:`, error.message);
-      return false;
-    }
-  }
-
   // Special handling for cgltf (single header with specific rawUrl)
   if (name === 'cgltf' && dep.rawUrl) {
     if (existsSync(destDir)) {