Merge pull request #291 from pobrn/dont_leak_WorkspaceThumbnails

Don't leak WorkspaceThumbnail objects

Author: mzur

[email protected]/workspacePopup/workspaceSwitcherPopup.js

@@ -195,6 +195,9 @@ class WorkspaceSwitcherPopup extends SwitcherPopup {
         while (modals.length > 0) {
             modals.pop().destroy();
         }
+
+        this._items.forEach((x) => x.destroy());
+        this._items = [];
     }
 
     vfunc_allocate(box) {

[email protected]/workspacePopup/workspaceSwitcherPopupList.js

@@ -42,8 +42,6 @@ export default GObject.registerClass({
             style: `spacing: ${ITEM_SPACING}`,
         });
         this._lists = [];
-        this._thumbnails = thumbnails;
-        this._workspaceName = workspaceName;
         this._scale = options.scale;
         this._showThumbnails = options.showThumbnails;
         this._showWorkspaceName = options.showWorkspaceNames;
@@ -75,7 +73,7 @@ export default GObject.registerClass({
                 () => this.highlight(workspaceManager.get_active_workspace_index()));
 
         for (let i = 0; i < thumbnails.length; i++) {
-            this.addItem(this._thumbnails[i], this._workspaceName[i]);
+            this.addItem(thumbnails[i], workspaceName[i]);
         }
     }