Skip to content

Commit 3f654f3

Browse files
committed
GNOME: add support for version 48
The extension was loading, but then I was unable to switch between workspaces. 'journalctl -f /usr/bin/gnome-shell' was showing some errors. The upgrading instructions [1] mentioned that: - _showWorkspaceSwitcher has a new 3rd argument: event, currently unused from what I see [2]. - Meta.disable_unredirect_for_display has been renamed and moved to a new namespace: Meta.Compositor.disable_unredirect. - We can get the Meta.Compositor using global.compositor. With these modifications, it looks like the extension can continue to work on GNOME v48. The minimum GNOME version is now 48. Link: https://gjs.guide/extensions/upgrading/gnome-shell-48.html [1] Link: https://github.com/GNOME/gnome-shell/blob/48.beta/js/ui/windowManager.js#L1747-L1846 [2] Signed-off-by: Matthieu Baerts <[email protected]>
1 parent 403c84a commit 3f654f3

File tree

4 files changed

+4
-4
lines changed

4 files changed

+4
-4
lines changed

[email protected]/metadata.json

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
11
{
22
"shell-version": [
3-
"47"
3+
"48"
44
],
55
"uuid": "[email protected]",
66
"url": "https://github.com/mzur/gnome-shell-wsmatrix",

[email protected]/workspacePopup/workspaceAnimation.js

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -251,6 +251,6 @@ export class WorkspaceAnimationController extends GWorkspaceAnimationController
251251
switchData.monitors.push(group);
252252
}
253253

254-
Meta.disable_unredirect_for_display(global.display);
254+
global.compositor.disable_unredirect();
255255
}
256256
}

[email protected]/workspacePopup/workspaceManagerOverride.js

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -380,7 +380,7 @@ export default class WorkspaceManagerOverride {
380380
* directions and using the WorkspaceSwitcherPopup (with constructor arguments)
381381
* provided by this extension.
382382
*/
383-
_showWorkspaceSwitcher(display, window, binding) {
383+
_showWorkspaceSwitcher(display, window, event, binding) {
384384
let workspaceManager = this.wsManager;
385385

386386
if (!Main.sessionMode.hasWorkspaces)

[email protected]/workspacePopup/workspaceSwitcherPopup.js

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -170,7 +170,7 @@ class WorkspaceSwitcherPopup extends SwitcherPopup {
170170
key = 'move-to-workspace-' + key.replace('move_to_workspace_', '');
171171
}
172172

173-
this._wm._showWorkspaceSwitcher(global.display, global.display.focus_window, key);
173+
this._wm._showWorkspaceSwitcher(global.display, global.display.focus_window, null, key);
174174
}
175175
}
176176

0 commit comments

Comments
 (0)