Skip to content

Commit ef065cd

Browse files
committed
fix: address PR feedback for iroh
1 parent 4a232b4 commit ef065cd

2 files changed

Lines changed: 2 additions & 6 deletions

File tree

.containerignore

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,2 @@
1+
target/
2+
.git/

iroh/src/socket/mapped_addrs.rs

Lines changed: 0 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -377,9 +377,6 @@ where
377377

378378
pub(super) fn retain(&self, mut f: impl FnMut(&K, &V) -> bool) {
379379
let mut inner = self.inner.lock().expect("poisoned");
380-
// Disjoint borrows: `addrs.retain` holds `addrs` mutably while the
381-
// closure also needs `lookup` — destructure so they aren't both
382-
// routed through `inner` (avoids E0499).
383380
let AddrMapInner { addrs, lookup } = &mut *inner;
384381
addrs.retain(|k, v| {
385382
let keep = f(k, v);
@@ -411,9 +408,6 @@ impl<K, V> Default for AddrMapInner<K, V> {
411408
mod tests {
412409
use super::*;
413410

414-
// The map is generic over the key, so a plain `u32` key exercises the
415-
// forward/reverse bookkeeping; `EndpointIdMappedAddr::generate()` is a
416-
// process-global counter with no other dependencies.
417411
#[test]
418412
fn remove_clears_forward_and_reverse_maps() {
419413
let map: AddrMap<u32, EndpointIdMappedAddr> = AddrMap::default();

0 commit comments

Comments
 (0)