Date strings not always in locale

[BertLindeman]

The localized date and times are not always translated,
see in issue 185

I think I found a reason.
In the forcast squares before the day.setText calls I added a setlocale and some prints.

Before and after the setlocale it shows:

BEFORE: in wxfinished_tm3 ('en_US', 'UTF-8') default: ('en_US', 'UTF-8')
AFTER   in wxfinished_tm3: ('nl_NL', 'UTF-8') default: ('en_US', 'UTF-8')

So each time e.g. wxfinished_tm3 is called the locale is again back to the default.

The setlocale is done in the function Tick.
I assume the function tick() runs as a separate thread (or something like it)
Could that be the reason that sometimes I saw the correct locale datea and most of the time not.

I copied the setting of the locale near line 2200 between:

width = rec.width()

signal.signal(signal.SIGINT, myquit)

I added there:

# ================== Set locale here to test if the dates/times ARE in the locales:

if Config.DateLocale != "":
    try:
        locale.setlocale(locale.LC_TIME, Config.DateLocale)
    except Exception as e:
        print("In Tick setlocale failed:", e, "\n\t", Config.DateLocale)
        raise SystemExit(1)

Could this be the cause?

In python3 I did not see a similar problem, but that can be a timing issue aswell.

[SerBrynden]

What happens when you move the following lines from the tick() function to the qtstart() function? Does that fix the issue?

if Config.DateLocale != "":
    try:
        locale.setlocale(locale.LC_TIME, Config.DateLocale)
    except:
        pass

[BertLindeman]

Looks like a good idea ;-)

Tried NL DE EN and all with openweathermap and tomorrow.io.
All Ok.

[n0bel]

@SerBrynden's suggestion is the best if it works. tick() is based on QTiimer, which could be a thread or message loop based depending in specific implementation. Setting locale should work 'globally', but you're seeing evidence of two versions of it. It is possible some other time manipulation functions are overriding locale (tz=tzlocal.get_localzone()) for example.

I did intentionally make DateLocale fail silently, in case the operating system does not have the locale set up.

Perhaps another solution is to set locale more often in code that displays data.

Thank you @BertLindeman for helping track this down.

[BertLindeman]

Setting locale more often might easily miss some place in the code where it should be. (not formulated very legible, sorry)
But doing it on the one location (and a correct one) would be better.

Another side remark: I did not see this problem running python3.
But not with this excact source due to print incompatibilites.

[SerBrynden]

I saw the same problem in my Python3 fork, until I moved the code to qtstart().

[n0bel]

pull request? or should I just make the change?

[BertLindeman]

I want to try.

[BertLindeman]

Not doing enough pull requests lately.

Created the pull request. Not sure if I now should close the pull request (now)
[EDIT] chatGPT made me clear that The "Close pull request" button is used to close the pull request without merging it

[SerBrynden]

My latest pull request #258 also fixes this.