Radar fixes, bug fixes, update config examples, PEP8 cleanup, etc. #258
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fix noise and ghosting in radar due to image objects created with uninitialized data. Fix typo in radar for RainViewer attribution. Fix crash with OWM forecast when current time is shortly after midnight and there may not be any forecast available after 6am for the final day. Replace night weather icons in OWM forecast with day icons. Change Tomorrow.io pressure from surface level to sea level, and metric units to mbar. Move setlocale from tick() to qtstart(). Add missing temperature units to forecast boxes. Add date to daily forecast boxes. Change background color for frame2 from blue to black, matching frame1. Fix typo in Config.py language specific wording from Waning Crecent to Waning Crescent. Expand attribution label to fit openweathermap.org. Remove unusual 15 multiplier from Tomorrow.io daily forecast snow precipitation intensity. Change math.abs() to abs() usage in feels_like() function. Add missing METAR station name after current weather timestamp when metric is selected. Remove the suppress_current global variable since it was made redundant by the hasMetar global variable. Use hasMetar in places where suppress_current was necessary. Fix wind gust imperial units in wxfinished_owm() from kph to mph. Add Radar instance attribute definitions that were missing from Radar __init__. Change Radar mapboxurl() and googlemapurl() to static methods. Remove usemapbox Boolean from Config.py and only set it based on existence of mbapi API key. Before, PiClock would check for both, which conflicted. Log errors from API calls and allow PiClock to continue without crash. Update all config examples. Optimize package imports. Remove unused variables. Remove global status from variables that don’t need it. PEP8 cleanup and other formatting changes. Many more bug fixes and improvements.
Contributor
Author
|
PR is stale |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@n0bel Sorry if this is a lot...
Fix noise and ghosting in radar due to image objects created with uninitialized data. fixes #157 fixes #190 fixes #241
Fix typo in radar for RainViewer attribution.
Fix crash with OWM forecast when current time is shortly after midnight and there may not be any forecast available after 6am for the final day.
Replace night weather icons in OWM forecast with day icons.
Change Tomorrow.io pressure from surface level to sea level, and metric units to mbar.
Move setlocale from tick() to qtstart(). fixes #256 fixes #257
Add missing temperature units to forecast boxes.
Add date to daily forecast boxes. fixes #255
Change background color for frame2 from blue to black, matching frame1.
Fix typo in Config.py language specific wording from Waning Crecent to Waning Crescent.
Expand attribution label to fit openweathermap.org.
Remove unusual 15 multiplier from Tomorrow.io daily forecast snow precipitation intensity.
Change math.abs() to abs() usage in feels_like() function.
Add missing METAR station name after current weather timestamp when metric is selected.
Remove the suppress_current global variable since it was made redundant by the hasMetar global variable. Use hasMetar in places where suppress_current was necessary.
Fix wind gust imperial units in wxfinished_owm() from kph to mph.
Add Radar instance attribute definitions that were missing from Radar init.
Change Radar mapboxurl() and googlemapurl() to static methods.
Remove usemapbox Boolean from Config.py and only set it based on existence of mbapi API key. Before, PiClock would check for both, which conflicted.
Log errors from API calls and allow PiClock to continue without crash.
Update all config examples.
Optimize package imports.
Remove unused variables.
Remove global status from variables that don’t need it.
PEP8 cleanup and other formatting changes.
Many more bug fixes and improvements.