Skip to content

DeleteResult type definition issue #138

@aresti

Description

@aresti

Thanks for the awesome library!

I noticed when building my own backend & driver for this that although DeleteResult is declared as:

src/adapters/types.ts

export interface DeleteResult {
  deleted: DirEntry[];
}

Code elsewhere seems to be expecting:

export interface DeleteResult extends FsData {
 deleted: DirEntry[];
}

and for example ArrayDriver's delete has:

// Also return updated listing so callers that expect files can update UI immediately
const op = this.resultForDir(params.path) as FileOperationResult;
return { ...op, deleted } as unknown as DeleteResult;

Which I don't think is currently covered in the docs at https://vuefinder.ozdemir.be/api-reference/drivers-interface.html#delete

Metadata

Metadata

Assignees

No one assigned

    Labels

    docsRelated to docs

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions