-
Notifications
You must be signed in to change notification settings - Fork 129
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Refactor jit plugin #1376
base: main
Are you sure you want to change the base?
Refactor jit plugin #1376
Conversation
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
The latest changes of this PR are not available as alpha, since there are no linked |
@kamilkisiela try rebasing with |
function jitExecute(args: ExecutionArgs) { | ||
const cacheEntry = getCacheEntry(args); | ||
|
||
return cacheEntry.query(args.rootValue, args.contextValue, args.variableValues); | ||
} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Once I use makeExecute
to make args
always an object (to make it v15,v16 compat), it adds an anonymous function on top of the original one which breaks the tests.
@saihaj
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I thought to not do makeExecuteFn
but take the private getExecuteArgs
function. This way we don't recreate a function over and over again.
eb6fe95
to
c2e01c5
Compare
@kamilkisiela Do you mind rebasing this and adding a PR description + changeset that describes the changes? |
@n1ru4l not this week |
a23dec1
to
3ac13be
Compare
🚨 IMPORTANT: Please do not create a Pull Request without creating an issue first.
Any change needs to be discussed before proceeding. Failure to do so may result in the rejection of the pull request.
Description
Please include a summary of the change and which issue is fixed. Please also include relevant motivation and context. List any dependencies that are required for this change.
Fixes # (issue)
Type of change
Please delete options that are not relevant.
Screenshots/Sandbox (if appropriate/relevant):
Adding links to sandbox or providing screenshots can help us understand more about this PR and take action on it as appropriate
How Has This Been Tested?
Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration
Test Environment:
@envelop/...
:Checklist:
Further comments
If this is a relatively large or complex change, kick off the discussion by explaining why you chose the solution you did and what alternatives you considered, etc...