Merge branch 'master' into ai-2358-bug-data-table-name-conflict-causes-builder-to-loop-and

Author: JoseBra

.claude/plugins/n8n/skills/create-community-node-lint-rule/SKILL.md

@@ -4,7 +4,6 @@ description: >-
   Use when adding a lint rule, creating a community node lint, or working on
   eslint-plugin-community-nodes. Guides rule implementation, tests, docs, and
   plugin registration.
-user_invocable: true
 ---
 
 # Create Community Node Lint Rule

.claude/plugins/n8n/skills/create-pr/SKILL.md

@@ -72,24 +72,17 @@ Creates GitHub PRs with titles that pass n8n's `check-pr-title` CI validation.
    git push -u origin HEAD
    ```
 
-6. **Create PR** using gh CLI with the template from `.github/pull_request_template.md`:
+6. **Create PR** using gh CLI. Read `.github/pull_request_template.md` as the
+   body structure, then populate each section with actual content before
+   creating the PR:
+   - **Summary**: describe what the PR does and how to test it
+   - **Related tickets**: add the Linear ticket URL (`https://linear.app/n8n/issue/[TICKET-ID]`) and any GitHub issue links
+   - **Checklist**: keep as-is from the template
+	 - Add a "🤖 PR Summary generated by AI" at the end of the body
+
    ```bash
    gh pr create --draft --title "<type>(<scope>): <summary>" --body "$(cat <<'EOF'
-   ## Summary
-
-   <Describe what the PR does and how to test. Photos and videos are recommended.>
-
-   ## Related Linear tickets, Github issues, and Community forum posts
-
-   <!-- Link to Linear ticket: https://linear.app/n8n/issue/[TICKET-ID] -->
-   <!-- Use "closes #<issue-number>", "fixes #<issue-number>", or "resolves #<issue-number>" to automatically close issues -->
-
-   ## Review / Merge checklist
-
-   - [ ] PR title and summary are descriptive. ([conventions](../blob/master/.github/pull_request_title_conventions.md))
-   - [ ] [Docs updated](https://github.com/n8n-io/n8n-docs) or follow-up ticket created.
-   - [ ] Tests included.
-   - [ ] PR Labeled with `release/backport` (if the PR is an urgent fix that needs to be backported)
+   <populated body based on pull_request_template.md>
    EOF
    )"
    ```
@@ -111,6 +104,7 @@ Based on `.github/pull_request_template.md`:
 
 ### Checklist
 All items should be addressed before merging:
+- The human author of the PR has checked the "I have seen this code, I have run this code, and I take responsibility for this code." checkbox
 - PR title follows conventions
 - Docs updated or follow-up ticket created
 - Tests included (bugs need regression tests, features need coverage)
@@ -191,5 +185,8 @@ Describe **what the code does**, not what threat it prevents.
 | Linear ref | URL with slug (leaks title) | URL without slug or ticket ID only |
 | Test name | `'should prevent SQL injection'` | `'should sanitize query parameters'` |
 
+
 **Before pushing a security fix, verify:** no branch name, commit, PR title,
 PR body, Linear URL, test name, or code comment hints at the vulnerability.
+
+**When in doubt, check the Linear issue for possible extra precautions**

.claude/plugins/n8n/skills/reproduce-bug/SKILL.md

@@ -1,6 +1,5 @@
 ---
 description: Reproduce a bug from a Linear ticket with a failing test. Expects the full ticket context (title, description, comments) to be provided as input.
-user_invocable: true
 ---
 
 # Bug Reproduction Framework

.github/pull_request_template.md

@@ -10,13 +10,14 @@ Photos and videos are recommended.
 <!--
 Include links to **Linear ticket** or Github issue or Community forum post.
 Important in order to close *automatically* and provide context to reviewers.
-https://linear.app/n8n/issue/
+https://linear.app/n8n/issue/[TICKET-ID]
 -->
 <!-- Use "closes #<issue-number>", "fixes #<issue-number>", or "resolves #<issue-number>" to automatically close issues when the PR is merged. -->
 
 
 ## Review / Merge checklist
 
+- [ ] I have seen this code, I have run this code, and I take responsibility for this code.
 - [ ] PR title and summary are descriptive. ([conventions](../blob/master/.github/pull_request_title_conventions.md)) <!--
    **Remember, the title automatically goes into the changelog.
    Use `(no-changelog)` otherwise.**

.github/scripts/package.json

@@ -1,14 +1,15 @@
 {
   "name": "workflow-scripts",
   "scripts": {
-    "test": "node --test --experimental-test-module-mocks ./*.test.mjs"
+    "test": "node --test --experimental-test-module-mocks ./*.test.mjs ./quality/*.test.mjs"
   },
   "dependencies": {
     "@actions/github": "9.0.0",
     "@octokit/core": "7.0.6",
     "conventional-changelog": "7.2.0",
     "debug": "4.4.3",
     "glob": "13.0.6",
+    "minimatch": "10.2.4",
     "semver": "7.7.4",
     "tempfile": "6.0.1"
   },

.github/scripts/pnpm-lock.yaml

@@ -0,0 +1,81 @@
+/**
+ * Checks that the PR description contains a checked ownership acknowledgement checkbox.
+ *
+ * Exit codes:
+ *   0 – Checkbox is present and checked
+ *   1 – Checkbox is missing or unchecked
+ */
+
+import { initGithub, getEventFromGithubEventPath } from '../github-helpers.mjs';
+
+const BOT_MARKER = '<!-- pr-ownership-check -->';
+
+/**
+ * Returns true if the PR body contains a checked ownership acknowledgement checkbox.
+ *
+ * @param {string | null | undefined} body
+ * @returns {boolean}
+ */
+export function isOwnershipCheckboxChecked(body) {
+	return /\[x\]\s+I have seen this code,\s+I have run this code,\s+and I take responsibility for this code/i.test(
+		body ?? '',
+	);
+}
+
+async function main() {
+	const event = getEventFromGithubEventPath();
+	const pr = event.pull_request;
+	const { octokit, owner, repo } = initGithub();
+
+	const { data: comments } = await octokit.rest.issues.listComments({
+		owner,
+		repo,
+		issue_number: pr.number,
+		per_page: 100,
+	});
+	const botComment = comments.find((c) => c.body.includes(BOT_MARKER));
+
+	if (!isOwnershipCheckboxChecked(pr.body)) {
+		const message = [
+			BOT_MARKER,
+			'## ⚠️ Ownership acknowledgement required',
+			'',
+			'Please add or check the following item in your PR description before this can be merged:',
+			'',
+			'```',
+			'- [x] I have seen this code, I have run this code, and I take responsibility for this code.',
+			'```',
+		].join('\n');
+
+		if (botComment) {
+			await octokit.rest.issues.updateComment({
+				owner,
+				repo,
+				comment_id: botComment.id,
+				body: message,
+			});
+		} else {
+			await octokit.rest.issues.createComment({
+				owner,
+				repo,
+				issue_number: pr.number,
+				body: message,
+			});
+		}
+
+		console.log(
+			'::error::Ownership checkbox is not checked. Add it to your PR description and check it.',
+		);
+		process.exit(1);
+	} else if (botComment) {
+		await octokit.rest.issues.deleteComment({
+			owner,
+			repo,
+			comment_id: botComment.id,
+		});
+	}
+}
+
+if (import.meta.url === `file://${process.argv[1]}`) {
+	await main();
+}

.github/scripts/quality/check-ownership-checkbox.mjs

@@ -0,0 +1,85 @@
+import { describe, it, before, mock } from 'node:test';
+import assert from 'node:assert/strict';
+
+/**
+ * Run with:
+ * node --test --experimental-test-module-mocks .github/scripts/quality/check-ownership-checkbox.test.mjs
+ */
+
+mock.module('../github-helpers.mjs', {
+	namedExports: {
+		initGithub: () => {},
+		getEventFromGithubEventPath: () => {},
+	},
+});
+
+let isOwnershipCheckboxChecked;
+before(async () => {
+	({ isOwnershipCheckboxChecked } = await import('./check-ownership-checkbox.mjs'));
+});
+
+describe('isOwnershipCheckboxChecked', () => {
+	it('returns true for a checked checkbox with exact text', () => {
+		const body =
+			'- [x] I have seen this code, I have run this code, and I take responsibility for this code.';
+		assert.ok(isOwnershipCheckboxChecked(body));
+	});
+
+	it('returns true for uppercase [X]', () => {
+		const body =
+			'- [X] I have seen this code, I have run this code, and I take responsibility for this code.';
+		assert.ok(isOwnershipCheckboxChecked(body));
+	});
+
+	it('returns false for an unchecked checkbox [ ]', () => {
+		const body =
+			'- [ ] I have seen this code, I have run this code, and I take responsibility for this code.';
+		assert.equal(isOwnershipCheckboxChecked(body), false);
+	});
+
+	it('returns false when the checkbox is absent', () => {
+		const body = '## Summary\n\nThis PR does some things.\n';
+		assert.equal(isOwnershipCheckboxChecked(body), false);
+	});
+
+	it('returns false for null body', () => {
+		assert.equal(isOwnershipCheckboxChecked(null), false);
+	});
+
+	it('returns false for undefined body', () => {
+		assert.equal(isOwnershipCheckboxChecked(undefined), false);
+	});
+
+	it('returns false for empty body', () => {
+		assert.equal(isOwnershipCheckboxChecked(''), false);
+	});
+
+	it('returns true when checkbox appears among other content', () => {
+		const body = [
+			'## Summary',
+			'',
+			'Some description here.',
+			'',
+			'## Checklist',
+			'- [x] Tests included',
+			'- [x] I have seen this code, I have run this code, and I take responsibility for this code.',
+			'- [ ] Docs updated',
+		].join('\n');
+		assert.ok(isOwnershipCheckboxChecked(body));
+	});
+
+	it('returns false when only other checkboxes are checked', () => {
+		const body = [
+			'- [x] Tests included',
+			'- [x] Docs updated',
+			'- [ ] I have seen this code, I have run this code, and I take responsibility for this code.',
+		].join('\n');
+		assert.equal(isOwnershipCheckboxChecked(body), false);
+	});
+
+	it('is case-insensitive for the checkbox marker', () => {
+		const lower =
+			'- [x] i have seen this code, i have run this code, and i take responsibility for this code.';
+		assert.ok(isOwnershipCheckboxChecked(lower));
+	});
+});