test: Ignore fixme tests in distribution script #24068
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
shortstacked
requested review from
a team and
seemewalkin
and removed request for
a team
![cubic-dev-ai[bot]](https://avatars.githubusercontent.com/in/1082092?s=60&v=4){kind=small}
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
|
E2E Tests: n8n tests passed after 5m 51.4s Run Details
Groups
This message was posted automatically by
currents.dev | Integration Settings
|
shortstacked
force-pushed
the
e2e-flaky-taskrunner
branch
from
9b5de43 to
d34bf79
Compare
This comment has been minimized.
This comment has been minimized.
shortstacked
changed the title
shortstacked
force-pushed
the
e2e-flaky-taskrunner
branch
from
82fb436 to
6a0805c
Compare
shortstacked
force-pushed
the
e2e-flaky-taskrunner
branch
from
93c8511 to
08eb6fe
Compare
seemewalkin
reviewed
Jan 9, 2026
Comment on lines
+116
to
+119
| **Why @fixme instead of test.skip?** | ||
| - `test.skip()` tests still appear in `--list` output and get distributed to shards | ||
| - `@fixme` tests are filtered out via `--grep-invert`, saving CI resources | ||
| - `test.fixme()` semantically indicates "needs fixing" vs "not applicable" |
seemewalkin
approved these changes
Jan 9, 2026
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
The distribution script was including skipped tests in it's sharding. Tests are now tagged as "fixme" so they can be skipped.
Task runners were shutdown between tests when unused, so when a test used it there was a delay due to cold start.
Related Linear tickets, Github issues, and Community forum posts
Review / Merge checklist
release/backport(if the PR is an urgent fix that needs to be backported)