Update controllers/gitrepository_controller_test.go

aleksanderaleksic · Copilot · web-flow · commit b4c24d28251c · 2025-12-21T07:04:15.000+01:00
Co-authored-by: Copilot &lt;175728472+Copilot@users.noreply.github.com&gt;
diff --git a/controllers/gitrepository_controller_test.go b/controllers/gitrepository_controller_test.go
@@ -525,7 +525,9 @@ func TestGitRepositoryReconciler_Reconcile_SkipNonGenericProviders(t *testing.T)
 			}
 
 			mockGitHubClient := &MockGitHubClient{}
-			// ValidateRepositoryURL should NOT be called since provider check happens first
+			// ValidateRepositoryURL should NOT be called: non-generic providers are managed by Flux
+			// itself and do not use this controller's GitHub token management, so the provider check
+			// short-circuits before any URL validation.
 
 			reconciler := &GitRepositoryReconciler{
 				Client:       fakeClient,

Original file line number	Diff line number	Diff line change
`@@ -525,7 +525,9 @@ func TestGitRepositoryReconciler_Reconcile_SkipNonGenericProviders(t *testing.T)`
`525`	`525`	`}`
`526`	`526`
`527`	`527`	`mockGitHubClient := &MockGitHubClient{}`
`528`		`- // ValidateRepositoryURL should NOT be called since provider check happens first`
	`528`	`+ // ValidateRepositoryURL should NOT be called: non-generic providers are managed by Flux`
	`529`	`+ // itself and do not use this controller's GitHub token management, so the provider check`
	`530`	`+ // short-circuits before any URL validation.`
`529`	`531`
`530`	`532`	`reconciler := &GitRepositoryReconciler{`
`531`	`533`	`Client: fakeClient,`