INSTALL: making sure the git clone status checks are predictable no matter the locale defined + keeping all git calls immune to explicit rebase config

Author: Commit-La-Grenouille

install.sh

@@ -76,7 +76,8 @@ if [ $upgrade -eq 1 -a $makerfaire2018 -eq 0 -a -d ${home_dir}/wm8960 ]; then
   echo "Updating sound driver - 2/14" > /tmp/pynab.upgrade
   cd ${home_dir}/wm8960
   sudo chown -R ${owner} .git
-  pull=`git pull`
+  # Making sure we keep the up-to-date status message consistent no matter the rebase default behavior
+  pull=$(LANGUAGE=en git pull --no-rebase)
   if [ "$pull" != "Already up to date." ]; then
     make && sudo make install && make clean
     sudo touch /tmp/pynab.upgrade.reboot
@@ -88,7 +89,8 @@ if [ $upgrade -eq 1 ]; then
   if [ -d ${home_dir}/tagtagtag-ears ]; then
     cd ${home_dir}/tagtagtag-ears
     sudo chown -R ${owner} .git
-    pull=`git pull`
+    # Making sure we keep the up-to-date status message consistent no matter the rebase default behavior
+    pull=$(LANGUAGE=en git pull --no-rebase)
     if [ "$pull" != "Already up to date." ]; then
       make && sudo make install && make clean
       sudo touch /tmp/pynab.upgrade.reboot
@@ -112,7 +114,8 @@ if [ $upgrade -eq 1 ]; then
   if [ -d ${home_dir}/cr14 ]; then
     cd ${home_dir}/cr14
     sudo chown -R ${owner} .git
-    pull=`git pull`
+    # Making sure we keep the up-to-date status message consistent no matter the rebase default behavior
+    pull=$(LANGUAGE=en git pull --no-rebase)
     if [ "$pull" != "Already up to date." ]; then
       make && sudo make install && make clean
       sudo touch /tmp/pynab.upgrade.reboot
@@ -135,8 +138,9 @@ if [ $upgrade -eq 1 ]; then
   echo "Updating NabBlockly - 5/14" > /tmp/pynab.upgrade
   if [ -d ${root_dir}/nabblockly ]; then
     cd ${root_dir}/nabblockly
-    sudo chown -R ${owner} .
-    pull=`git pull`
+    sudo chown -R ${owner}
+    # Making sure we keep the up-to-date status message consistent no matter the rebase default behavior
+    pull=$(LANGUAGE=en git pull --no-rebase)
     if [ "$pull" != "Already up to date." ]; then
       ./rebar3 release
     fi

upgrade.sh

@@ -25,17 +25,17 @@ case $step in
     done
     sudo systemctl stop nabd.socket || echo -n ""
     sudo systemctl stop nabd.service || echo -n ""
-  
+
     sudo -u ${owner} touch /tmp/pynab.upgrade
     sudo chown ${owner} /tmp/pynab.upgrade
     echo "Updating code - 1/?" > /tmp/pynab.upgrade
     cd ${root_dir}
     if [[ $EUID -ne ${ownerid} ]]; then
-      sudo -u ${owner} git pull
+      sudo -u ${owner} git pull --no-rebase
     else
-      git pull
+      git pull --no-rebase
     fi
-  
+
     bash upgrade.sh "install"
     ;;
   "install")