fix: create problems in competition edit

Author: gardenerik

bullet/bullet_admin/forms/competition.py

@@ -1,7 +1,7 @@
 from competitions.models import Competition
 from django import forms
 from django.core.validators import FileExtensionValidator
-from users.models import User
+from problems.models import Problem
 
 
 class CompetitionForm(forms.ModelForm):
@@ -38,8 +38,20 @@ class Meta:
             "competition_start": forms.DateTimeInput(attrs={"type": "datetime"}),
         }
 
-    def __init__(self, user: User, **kwargs):
-        super().__init__(**kwargs)
+    def save(self, commit: bool = True):
+        obj = super().save(commit=True)
+
+        current_problems = Problem.objects.filter(competition=obj)
+        current_count = current_problems.count()
+        requested_count = self.cleaned_data["problem_count"]
+        if current_count != requested_count:
+            if current_count > requested_count:
+                current_problems.filter(number__gt=requested_count).delete()
+            else:
+                for i in range(current_count + 1, requested_count + 1):
+                    Problem.objects.create(competition=obj, number=i)
+
+        return obj
 
 
 class TearoffUploadForm(forms.Form):

bullet/bullet_admin/views/competition.py

@@ -20,16 +20,8 @@
 from bullet_admin.views import GenericForm
 
 
-class CompetitionFormMixin(GenericForm):
+class CompetitionUpdateView(BranchAdminAccess, UpdateView):
     form_class = CompetitionForm
-
-    def get_form_kwargs(self):
-        kw = super().get_form_kwargs()
-        kw["user"] = self.request.user
-        return kw
-
-
-class CompetitionUpdateView(BranchAdminAccess, CompetitionFormMixin, UpdateView):
     form_title = "Edit competition"
     template_name = "bullet_admin/competition/form.html"
 
@@ -40,7 +32,8 @@ def get_success_url(self):
         return reverse("badmin:competition_switch")
 
 
-class CompetitionCreateView(BranchAdminAccess, CompetitionFormMixin, CreateView):
+class CompetitionCreateView(BranchAdminAccess, CreateView):
+    form_class = CompetitionForm
     form_title = "New competition"
 
     def form_valid(self, form):