Skip to content

Commit 7491604

Browse files
committed
return RedirectBackMixin to album views
1 parent b08d6c3 commit 7491604

File tree

2 files changed

+6
-5
lines changed

2 files changed

+6
-5
lines changed

bullet/bullet_admin/mixins.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -124,7 +124,7 @@ def get_context_data(self, **kwargs):
124124
class RedirectBackMixin:
125125
default_success_url = None
126126

127-
def get_default_success_url(self):
127+
def get_default_success_url(self) -> str:
128128
if self.default_success_url:
129129
return self.default_success_url
130130

bullet/bullet_admin/views/albums.py

Lines changed: 5 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -11,6 +11,7 @@
1111

1212
from bullet_admin.access import PhotoUploadAccess
1313
from bullet_admin.forms.album import AlbumForm
14+
from bullet_admin.mixins import RedirectBackMixin
1415
from bullet_admin.utils import get_active_competition
1516
from bullet_admin.views import GenericDelete, GenericForm, GenericList
1617

@@ -53,7 +54,7 @@ def dispatch(self, request, *args, **kwargs):
5354
return super().dispatch(request, *args, **kwargs)
5455

5556

56-
class AlbumFormMixin(GenericForm):
57+
class AlbumFormMixin(RedirectBackMixin, GenericForm):
5758
form_class = AlbumForm
5859
form_multipart = True
5960

@@ -80,7 +81,7 @@ def form_valid(self, form):
8081
photo.save()
8182
return HttpResponseRedirect(self.get_success_url())
8283

83-
def get_success_url(self):
84+
def get_default_success_url(self):
8485
return reverse("badmin:album_edit", kwargs={"pk": self.object.id})
8586

8687

@@ -105,9 +106,9 @@ def form_valid(self, form):
105106
return ret
106107

107108

108-
class AlbumDeleteView(PhotoUploadAccess, GenericDelete, DeleteView):
109+
class AlbumDeleteView(PhotoUploadAccess, RedirectBackMixin, GenericDelete, DeleteView):
109110
model = Album
110-
success_url = reverse_lazy("badmin:album_list")
111+
default_success_url = reverse_lazy("badmin:album_list")
111112

112113
def form_valid(self, form):
113114
super().form_valid(form)

0 commit comments

Comments
 (0)