Skip to content

Commit c2c5df0

Browse files
authored
feat: remove Logo model (#991)
1 parent 2ffb989 commit c2c5df0

File tree

17 files changed

+21
-421
lines changed

17 files changed

+21
-421
lines changed

bullet/bullet_admin/forms/content.py

Lines changed: 1 addition & 28 deletions
Original file line numberDiff line numberDiff line change
@@ -5,7 +5,7 @@
55
from django.utils.translation import get_language_info
66
from django_countries import countries
77
from django_countries.fields import Country
8-
from web.models import ContentBlock, Logo, Menu, Page, PageBlock
8+
from web.models import ContentBlock, Menu, Page, PageBlock
99

1010

1111
class PageForm(forms.ModelForm):
@@ -156,33 +156,6 @@ def clean(self):
156156
return cleaned_data
157157

158158

159-
class LogoForm(forms.ModelForm):
160-
class Meta:
161-
model = Logo
162-
fields = ("type", "name", "url", "image", "countries")
163-
164-
widgets = {
165-
"countries": forms.CheckboxSelectMultiple(),
166-
}
167-
168-
def __init__(self, branch: Branch, **kwargs):
169-
super().__init__(**kwargs)
170-
available_countries = set()
171-
172-
for country in BranchCountry.objects.filter(branch=branch).all():
173-
available_countries.add(country.country.code)
174-
175-
self.fields["countries"].choices = list(
176-
sorted(
177-
filter(
178-
lambda x: x[0] in available_countries,
179-
self.fields["countries"].choices,
180-
),
181-
key=lambda x: x[1],
182-
)
183-
)
184-
185-
186159
class MenuItemForm(forms.ModelForm):
187160
class Meta:
188161
model = Menu

bullet/bullet_admin/templates/bullet_admin/content/logo_form.html

Lines changed: 0 additions & 45 deletions
This file was deleted.

bullet/bullet_admin/templates/bullet_admin/content/logo_list.html

Lines changed: 0 additions & 56 deletions
This file was deleted.

bullet/bullet_admin/templatetags/badmin.py

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -69,7 +69,6 @@ def admin_sidebar(context):
6969
(
7070
("fa-file-text", "Pages", reverse("badmin:page_list")),
7171
("fa-cube", "Blocks", reverse("badmin:contentblock_list")),
72-
("fa-handshake", "Logos", reverse("badmin:logo_list")),
7372
("fa-bars", "Menu items", reverse("badmin:menu_list")),
7473
("fa-folder", "File browser", reverse("badmin:file_tree")),
7574
),

bullet/bullet_admin/urls/__init__.py

Lines changed: 0 additions & 20 deletions
Original file line numberDiff line numberDiff line change
@@ -135,26 +135,6 @@
135135
content.ContentBlockDeleteView.as_view(),
136136
name="contentblock_delete",
137137
),
138-
path(
139-
"content/logos/",
140-
content.LogoListView.as_view(),
141-
name="logo_list",
142-
),
143-
path(
144-
"content/logos/edit/<pk>/",
145-
content.LogoEditView.as_view(),
146-
name="logo_edit",
147-
),
148-
path(
149-
"content/logos/create/",
150-
content.LogoCreateView.as_view(),
151-
name="logo_create",
152-
),
153-
path(
154-
"content/logos/delete/<pk>/",
155-
content.LogoDeleteView.as_view(),
156-
name="logo_delete",
157-
),
158138
path(
159139
"content/menu/",
160140
content.MenuItemListView.as_view(),

bullet/bullet_admin/views/content.py

Lines changed: 1 addition & 53 deletions
Original file line numberDiff line numberDiff line change
@@ -6,13 +6,12 @@
66
from django.urls import reverse, reverse_lazy
77
from django.utils.functional import cached_property
88
from django.views.generic import CreateView, DeleteView, FormView, ListView, UpdateView
9-
from web.models import ContentBlock, Logo, Menu, Page, PageBlock
9+
from web.models import ContentBlock, Menu, Page, PageBlock
1010

1111
from bullet.views import FormAndFormsetMixin
1212
from bullet_admin.forms.content import (
1313
ContentBlockForm,
1414
ContentBlockWithRefForm,
15-
LogoForm,
1615
MenuItemForm,
1716
PageBlockCreateForm,
1817
PageBlockUpdateForm,
@@ -371,57 +370,6 @@ def form_valid(self, form):
371370
)
372371

373372

374-
class LogoListView(TranslatorRequiredMixin, ListView):
375-
template_name = "bullet_admin/content/logo_list.html"
376-
377-
def get_queryset(self):
378-
return Logo.objects.filter(branch=self.request.BRANCH)
379-
380-
381-
class LogoEditView(TranslatorRequiredMixin, UpdateView):
382-
template_name = "bullet_admin/content/logo_form.html"
383-
form_class = LogoForm
384-
385-
def get_form_kwargs(self):
386-
kw = super().get_form_kwargs()
387-
kw["branch"] = self.request.BRANCH
388-
return kw
389-
390-
def get_queryset(self):
391-
return Logo.objects.filter(branch=self.request.BRANCH)
392-
393-
def get_success_url(self):
394-
return reverse("badmin:logo_list")
395-
396-
397-
class LogoCreateView(TranslatorRequiredMixin, CreateView):
398-
template_name = "bullet_admin/content/logo_form.html"
399-
form_class = LogoForm
400-
401-
def get_form_kwargs(self):
402-
kw = super().get_form_kwargs()
403-
kw["branch"] = self.request.BRANCH
404-
return kw
405-
406-
def get_success_url(self):
407-
return reverse("badmin:logo_list")
408-
409-
def form_valid(self, form):
410-
obj = form.save(commit=False)
411-
obj.branch = self.request.BRANCH.id
412-
obj.save()
413-
414-
return HttpResponseRedirect(reverse("badmin:logo_list"))
415-
416-
417-
class LogoDeleteView(TranslatorRequiredMixin, BDeleteView):
418-
def get_queryset(self):
419-
return Logo.objects.filter(branch=self.request.BRANCH)
420-
421-
def get_success_url(self):
422-
return reverse("badmin:logo_list")
423-
424-
425373
class MenuItemListView(TranslatorRequiredMixin, GenericList, ListView):
426374
create_url = reverse_lazy("badmin:menu_create")
427375
fields = ["title", "url", "order", "language", "countries"]

bullet/competitions/management/commands/generatedata.py

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -10,7 +10,7 @@
1010
from education.factories.generate import create_education
1111
from problems.factories.generate import create_problems
1212
from users.factories.generate import create_users
13-
from web.factories.generate import create_pages, create_partners
13+
from web.factories.generate import create_pages
1414

1515
from bullet import search
1616

@@ -35,6 +35,5 @@ def handle(self, *args, **options):
3535
)
3636
create_problems(competition_physics)
3737

38-
create_partners()
3938
create_users(competition_physics)
4039
management.call_command("indexschools")

bullet/web/admin.py

Lines changed: 1 addition & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
11
from django.contrib import admin
22

3-
from web.models import ContentBlock, Logo, Menu, Page, PageBlock
3+
from web.models import ContentBlock, Menu, Page, PageBlock
44

55
admin.site.site_title = "Bullet system administration"
66
admin.site.site_header = "Bullet system administration"
@@ -12,12 +12,6 @@ class PageAdmin(admin.ModelAdmin):
1212
list_filter = ["branch", "language", "slug"]
1313

1414

15-
@admin.register(Logo)
16-
class LogoAdmin(admin.ModelAdmin):
17-
list_display = ["branch", "type", "name", "countries"]
18-
list_filter = ["branch", "type"]
19-
20-
2115
@admin.register(Menu)
2216
class MenuAdmin(admin.ModelAdmin):
2317
list_display = ["title", "branch", "language", "countries", "url", "order"]

bullet/web/factories/generate.py

Lines changed: 0 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -3,7 +3,6 @@
33
from django.db.models import QuerySet
44
from web.factories.menu import MenuFactory
55
from web.factories.pages import PageFactory
6-
from web.factories.partners import LogoFactory
76

87

98
def create_pages(branch: Branch):
@@ -39,7 +38,3 @@ def create_pages(branch: Branch):
3938
countries=countries,
4039
external=True,
4140
)
42-
43-
44-
def create_partners():
45-
LogoFactory.create_batch(50)

bullet/web/factories/partners.py

Lines changed: 0 additions & 38 deletions
This file was deleted.

0 commit comments

Comments
 (0)