fix: competition creation

Co-authored-by: Adam Zahradník <[email protected]>

Author: Aiq0

CHANGELOG.md

@@ -3,6 +3,12 @@
 The format is based on [Keep a Changelog](https://keepachangelog.com/en/1.0.0/),
 and this project uses the `YYYY.N` version format.
 
+## 2025.18 - 2025-07-10
+
+### Fixed
+
+- Fixed competition creation.
+
 ## 2025.17 - 2025-06-18
 
 ### Fixed

bullet/bullet_admin/forms/competition.py

@@ -38,8 +38,14 @@ class Meta:
             "competition_start": forms.DateTimeInput(attrs={"type": "datetime"}),
         }
 
+    def __init__(self, branch, **kwargs):
+        self.branch = branch
+        super().__init__(**kwargs)
+
     def save(self, commit: bool = True):
-        obj = super().save(commit=True)
+        obj = super()
+        obj.branch = self.branch
+        obj.save(commit=True)
 
         current_problems = Problem.objects.filter(competition=obj)
         current_count = current_problems.count()

bullet/bullet_admin/views/competition.py

@@ -35,17 +35,23 @@ def get_object(self, queryset=None):
     def get_success_url(self):
         return reverse("badmin:competition_switch")
 
+    def get_form_kwargs(self):
+        kwargs = super().get_form_kwargs()
+        kwargs["branch"] = self.request.BRANCH
+        return kwargs
+
 
 class CompetitionCreateView(BranchAdminAccess, GenericForm, CreateView):
     form_class = CompetitionForm
     form_title = "New competition"
 
-    def form_valid(self, form):
-        competition: Competition = form.save(commit=False)
-        competition.branch = self.request.BRANCH
-        competition.save()
+    def get_success_url(self):
+        return reverse("badmin:competition_switch")
 
-        return redirect("badmin:competition_switch")
+    def get_form_kwargs(self):
+        kwargs = super().get_form_kwargs()
+        kwargs["branch"] = self.request.BRANCH
+        return kwargs
 
 
 class CompetitionFinalizeView(UnlockedCompetitionMixin, BranchAdminAccess, FormView):