Merge pull request #71 from naiba/feat/sync-seeded-translations

feat: sync seeded entity translations when user changes locale

Author: naiba

server/internal/handlers/handlers_test.go

@@ -4,17 +4,18 @@ import (
 	"bytes"
 	"encoding/json"
 	"fmt"
-	"os"
 	"mime/multipart"
 	"net/http"
 	"net/http/httptest"
 	"net/textproto"
+	"os"
 	"strings"
 	"testing"
 
 	"github.com/labstack/echo/v4"
 	"github.com/naiba/bonds/internal/config"
 	"github.com/naiba/bonds/internal/handlers"
+	"github.com/naiba/bonds/internal/middleware"
 	"github.com/naiba/bonds/internal/models"
 	"github.com/naiba/bonds/internal/services"
 	"github.com/naiba/bonds/internal/testutil"
@@ -933,7 +934,6 @@ func TestContactList_Pagination(t *testing.T) {
 	}
 }
 
-
 func TestContactList_FilterArchived(t *testing.T) {
 	ts := setupTestServer(t)
 	token, _ := ts.registerTestUser(t, "cfilter@example.com")
@@ -1721,8 +1721,10 @@ func TestSearch_VaultIsolation(t *testing.T) {
 	}
 	resp := parseResponse(t, rec)
 	var searchResp struct {
-		Contacts []struct{ ID string `json:"id"` } `json:"contacts"`
-		Total    int                                  `json:"total"`
+		Contacts []struct {
+			ID string `json:"id"`
+		} `json:"contacts"`
+		Total int `json:"total"`
 	}
 	json.Unmarshal(resp.Data, &searchResp)
 	if len(searchResp.Contacts) != 0 {
@@ -4353,7 +4355,6 @@ func TestPersonalAccessToken_AuthWithExpiredPAT(t *testing.T) {
 	}
 }
 
-
 // ==================== ListForContact ====================
 
 func TestListForContact_ReturnsOnlyAssigned(t *testing.T) {
@@ -4532,7 +4533,9 @@ func TestLifeEvent_CreateWithValidType(t *testing.T) {
 		t.Fatalf("create timeline: expected 201, got %d: %s", rec.Code, rec.Body.String())
 	}
 	resp := parseResponse(t, rec)
-	var teData struct{ ID uint `json:"id"` }
+	var teData struct {
+		ID uint `json:"id"`
+	}
 	if err := json.Unmarshal(resp.Data, &teData); err != nil {
 		t.Fatalf("failed to parse timeline: %v", err)
 	}
@@ -4643,7 +4646,9 @@ func TestLifeEvent_ListViaTimeline(t *testing.T) {
 	rec := ts.doRequest(http.MethodPost, "/api/vaults/"+vault.ID+"/contacts/"+contact.ID+"/timelineEvents",
 		`{"started_at":"2026-01-01T00:00:00Z","label":"Timeline"}`, token)
 	resp := parseResponse(t, rec)
-	var teData struct{ ID uint `json:"id"` }
+	var teData struct {
+		ID uint `json:"id"`
+	}
 	json.Unmarshal(resp.Data, &teData)
 
 	// Get valid type ID
@@ -5030,4 +5035,69 @@ func TestCompanyEmployee_AddAndRemove(t *testing.T) {
 	if len(companyAfter.Contacts) != 0 {
 		t.Errorf("expected 0 employees after remove, got %d", len(companyAfter.Contacts))
 	}
-}
+}
+
+func (ts *testServer) doRequestWithLocale(method, path, body, token, locale string) *httptest.ResponseRecorder {
+	var req *http.Request
+	if body != "" {
+		req = httptest.NewRequest(method, path, strings.NewReader(body))
+		req.Header.Set("Content-Type", "application/json")
+	} else {
+		req = httptest.NewRequest(method, path, nil)
+	}
+	if token != "" {
+		req.Header.Set("Authorization", "Bearer "+token)
+	}
+	if locale != "" {
+		req.Header.Set("Accept-Language", locale)
+	}
+	rec := httptest.NewRecorder()
+	ts.e.ServeHTTP(rec, req)
+	return rec
+}
+
+func TestSyncTranslations_Success(t *testing.T) {
+	ts := setupTestServer(t)
+	ts.e.Use(middleware.Locale())
+	token, _ := ts.registerTestUser(t, "sync-handler@example.com")
+
+	rec := ts.doRequestWithLocale(http.MethodPost, "/api/settings/personalize/sync", "", token, "zh")
+	if rec.Code != http.StatusOK {
+		t.Fatalf("expected 200, got %d: %s", rec.Code, rec.Body.String())
+	}
+	resp := parseResponse(t, rec)
+	if !resp.Success {
+		t.Fatal("expected success=true")
+	}
+
+	rec = ts.doRequestWithLocale(http.MethodGet, "/api/settings/personalize/genders", "", token, "zh")
+	if rec.Code != http.StatusOK {
+		t.Fatalf("list genders: expected 200, got %d: %s", rec.Code, rec.Body.String())
+	}
+	resp = parseResponse(t, rec)
+	var genders []struct {
+		Name string `json:"name"`
+	}
+	if err := json.Unmarshal(resp.Data, &genders); err != nil {
+		t.Fatalf("failed to parse genders: %v", err)
+	}
+	foundChinese := false
+	for _, g := range genders {
+		if g.Name == "男" {
+			foundChinese = true
+			break
+		}
+	}
+	if !foundChinese {
+		t.Fatalf("expected Chinese '男' after sync, got: %v", genders)
+	}
+}
+
+func TestSyncTranslations_Unauthorized(t *testing.T) {
+	ts := setupTestServer(t)
+
+	rec := ts.doRequest(http.MethodPost, "/api/settings/personalize/sync", "", "")
+	if rec.Code != http.StatusUnauthorized {
+		t.Fatalf("expected 401, got %d", rec.Code)
+	}
+}

server/internal/handlers/personalize.go

@@ -159,3 +159,24 @@ func (h *PersonalizeHandler) Delete(c echo.Context) error {
 	}
 	return response.NoContent(c)
 }
+
+// SyncTranslations godoc
+//
+//	@Summary		Sync seeded entity translations
+//	@Description	Re-translate all default seeded labels to match the current locale (from Accept-Language header). Custom labels are not affected.
+//	@Tags			personalize
+//	@Produce		json
+//	@Security		BearerAuth
+//	@Success		200	{object}	response.APIResponse
+//	@Failure		401	{object}	response.APIResponse
+//	@Failure		500	{object}	response.APIResponse
+//	@Router			/settings/personalize/sync [post]
+func (h *PersonalizeHandler) SyncTranslations(c echo.Context) error {
+	accountID := middleware.GetAccountID(c)
+	locale := middleware.GetLocale(c)
+
+	if err := h.personalizeService.SyncAllTranslations(accountID, locale); err != nil {
+		return response.InternalError(c, "err.failed_to_sync_translations")
+	}
+	return response.OK(c, nil)
+}

server/internal/handlers/routes.go

@@ -600,6 +600,7 @@ func RegisterRoutes(e *echo.Echo, db *gorm.DB, cfg *config.Config, version strin
 	notifGroup.GET("/:id/logs", notificationHandler.ListLogs)
 
 	personalizeGroup := settingsGroup.Group("/personalize", authMiddleware.RequireAdmin)
+	personalizeGroup.POST("/sync", personalizeHandler.SyncTranslations)
 	personalizeGroup.PUT("/currencies/:currencyId/toggle", currencyHandler.Toggle)
 	personalizeGroup.POST("/currencies/enable-all", currencyHandler.EnableAll)
 	personalizeGroup.DELETE("/currencies/disable-all", currencyHandler.DisableAll)

server/internal/middleware/locale.go

@@ -23,6 +23,8 @@ func Locale() echo.MiddlewareFunc {
 				primary = strings.ToLower(primary)
 				if primary == "zh" {
 					lang = "zh"
+				} else if primary == "es" {
+					lang = "es"
 				}
 			}
 			c.Set("locale", lang)

server/internal/services/personalize.go

@@ -5,6 +5,7 @@ import (
 	"fmt"
 
 	"github.com/naiba/bonds/internal/dto"
+	"github.com/naiba/bonds/internal/i18n"
 	"gorm.io/gorm"
 )
 
@@ -176,3 +177,95 @@ func (s *PersonalizeService) ListTemplates(accountID string) ([]map[string]inter
 	}
 	return results, nil
 }
+
+type syncableEntity struct {
+	table         string
+	displayCol    string
+	keyCol        string
+	ownerCol      string
+	parentTable   string
+	parentJoinCol string
+}
+
+var accountSyncEntities = []syncableEntity{
+	{table: "genders", displayCol: "name", keyCol: "name_translation_key", ownerCol: "account_id"},
+	{table: "pronouns", displayCol: "name", keyCol: "name_translation_key", ownerCol: "account_id"},
+	{table: "address_types", displayCol: "name", keyCol: "name_translation_key", ownerCol: "account_id"},
+	{table: "pet_categories", displayCol: "name", keyCol: "name_translation_key", ownerCol: "account_id"},
+	{table: "contact_information_types", displayCol: "name", keyCol: "name_translation_key", ownerCol: "account_id"},
+	{table: "relationship_group_types", displayCol: "name", keyCol: "name_translation_key", ownerCol: "account_id"},
+	{table: "relationship_types", displayCol: "name", keyCol: "name_translation_key", ownerCol: "account_id", parentTable: "relationship_group_types", parentJoinCol: "relationship_group_type_id"},
+	{table: "relationship_types", displayCol: "name_reverse_relationship", keyCol: "name_reverse_relationship_translation_key", ownerCol: "account_id", parentTable: "relationship_group_types", parentJoinCol: "relationship_group_type_id"},
+	{table: "call_reason_types", displayCol: "label", keyCol: "label_translation_key", ownerCol: "account_id"},
+	{table: "call_reasons", displayCol: "label", keyCol: "label_translation_key", ownerCol: "account_id", parentTable: "call_reason_types", parentJoinCol: "call_reason_type_id"},
+	{table: "religions", displayCol: "name", keyCol: "translation_key", ownerCol: "account_id"},
+	{table: "group_types", displayCol: "label", keyCol: "label_translation_key", ownerCol: "account_id"},
+	{table: "group_type_roles", displayCol: "label", keyCol: "label_translation_key", ownerCol: "account_id", parentTable: "group_types", parentJoinCol: "group_type_id"},
+	{table: "emotions", displayCol: "name", keyCol: "name_translation_key", ownerCol: "account_id"},
+	{table: "gift_occasions", displayCol: "label", keyCol: "label_translation_key", ownerCol: "account_id"},
+	{table: "gift_states", displayCol: "label", keyCol: "label_translation_key", ownerCol: "account_id"},
+	{table: "post_templates", displayCol: "label", keyCol: "label_translation_key", ownerCol: "account_id"},
+	{table: "templates", displayCol: "name", keyCol: "name_translation_key", ownerCol: "account_id"},
+	{table: "template_pages", displayCol: "name", keyCol: "name_translation_key", ownerCol: "account_id", parentTable: "templates", parentJoinCol: "template_id"},
+	{table: "modules", displayCol: "name", keyCol: "name_translation_key", ownerCol: "account_id"},
+}
+
+var vaultSyncEntities = []syncableEntity{
+	{table: "mood_tracking_parameters", displayCol: "label", keyCol: "label_translation_key", ownerCol: "vault_id"},
+	{table: "life_event_categories", displayCol: "label", keyCol: "label_translation_key", ownerCol: "vault_id"},
+	{table: "life_event_types", displayCol: "label", keyCol: "label_translation_key", ownerCol: "vault_id", parentTable: "life_event_categories", parentJoinCol: "life_event_category_id"},
+	{table: "vault_quick_facts_templates", displayCol: "label", keyCol: "label_translation_key", ownerCol: "vault_id"},
+}
+
+func (s *PersonalizeService) SyncAllTranslations(accountID, locale string) error {
+	return s.db.Transaction(func(tx *gorm.DB) error {
+		if err := syncEntities(tx, accountSyncEntities, accountID, locale); err != nil {
+			return err
+		}
+
+		var vaultIDs []string
+		if err := tx.Table("vaults").Where("account_id = ?", accountID).Pluck("id", &vaultIDs).Error; err != nil {
+			return err
+		}
+		for _, vaultID := range vaultIDs {
+			if err := syncEntities(tx, vaultSyncEntities, vaultID, locale); err != nil {
+				return err
+			}
+		}
+		return nil
+	})
+}
+
+func syncEntities(tx *gorm.DB, entities []syncableEntity, ownerID, locale string) error {
+	for _, e := range entities {
+		var rows []struct {
+			ID  uint   `gorm:"column:id"`
+			Key string `gorm:"column:key"`
+		}
+
+		query := tx.Table(e.table).Select("id, " + e.keyCol + " AS key").
+			Where(e.keyCol + " IS NOT NULL AND " + e.keyCol + " != ''")
+
+		if e.parentTable != "" {
+			query = query.Where(
+				fmt.Sprintf("%s IN (SELECT id FROM %s WHERE %s = ?)", e.parentJoinCol, e.parentTable, e.ownerCol),
+				ownerID,
+			)
+		} else {
+			query = query.Where(e.ownerCol+" = ?", ownerID)
+		}
+
+		if err := query.Find(&rows).Error; err != nil {
+			return err
+		}
+
+		for _, row := range rows {
+			translated := i18n.T(locale, row.Key)
+			if err := tx.Table(e.table).Where("id = ?", row.ID).
+				Update(e.displayCol, translated).Error; err != nil {
+				return err
+			}
+		}
+	}
+	return nil
+}