lints

Author: batconjurer

masp_proofs/src/downloadreader.rs

@@ -62,7 +62,7 @@ impl io::Read for ResponseLazyReader {
                                 let error = format!("download response failed: {:?}", error);
 
                                 *self = Complete(Err(error.clone()));
-                                return Err(io::Error::new(io::ErrorKind::Other, error));
+                                return Err(io::Error::other(error));
                             }
                         }
                     }
@@ -75,7 +75,7 @@ impl io::Read for ResponseLazyReader {
                         // Return a zero-byte read for download success and EOF.
                         Ok(()) => Ok(0),
                         // Keep returning the download error,
-                        Err(error) => Err(io::Error::new(io::ErrorKind::Other, error.clone())),
+                        Err(error) => Err(io::Error::other(error.clone())),
                     };
                 }
             }

masp_proofs/src/lib.rs

@@ -142,9 +142,8 @@ fn fetch_params(
     timeout: Option<u64>,
 ) -> Result<PathBuf, minreq::Error> {
     // Ensure that the default MASP parameters location exists.
-    let params_dir = default_params_folder().ok_or_else(|| {
-        io::Error::new(io::ErrorKind::Other, "Could not load default params folder")
-    })?;
+    let params_dir = default_params_folder()
+        .ok_or_else(|| io::Error::other("Could not load default params folder"))?;
     std::fs::create_dir_all(&params_dir)?;
 
     let params_path = params_dir.join(name);

masp_proofs/src/sapling/verifier/batch.rs

@@ -1,3 +1,5 @@
+#[cfg(feature = "benchmarks")]
+use bellman::groth16::prepare_verifying_key;
 use bellman::groth16::{PreparedVerifyingKey, Proof};
 use bellman::{SynthesisError, groth16};
 use bls12_381::Bls12;