minors (#64)

* minors

* minors

* minors

Author: Fraccaman

run.sh

@@ -1,4 +1,4 @@
 . .env
 export CHAIN_ID
 export RPC
-cargo run 
+RUST_BACKTRACE=1 cargo run 

src/checks/block.rs

@@ -1,4 +1,4 @@
-use std::time::Duration;
+use std::{fmt::Display, time::Duration};
 
 use crate::shared::alert::Metadata;
 
@@ -43,6 +43,16 @@ impl CheckTrait for BlockCheck {
     }
 }
 
+impl Display for BlockCheck {
+    fn fmt(&self, f: &mut std::fmt::Formatter<'_>) -> std::fmt::Result {
+        write!(
+            f,
+            "BlockCheck(estimated_block_time: {}, block_time_deviation: {})",
+            self.estimated_block_time, self.block_time_deviation
+        )
+    }
+}
+
 impl BlockCheck {
     pub fn new(config: &AppConfig) -> Self {
         let config = config.get_config();

src/checks/fees.rs

@@ -5,7 +5,7 @@ use crate::{
 };
 
 use super::{AppConfig, CheckTrait};
-use std::collections::HashMap;
+use std::{collections::HashMap, fmt::Display};
 
 const FEE_CHECK_ID: &str = "fee_check";
 
@@ -82,3 +82,9 @@ impl CheckTrait for FeeCheck {
         false
     }
 }
+
+impl Display for FeeCheck {
+    fn fmt(&self, f: &mut std::fmt::Formatter<'_>) -> std::fmt::Result {
+        write!(f, "FeeCheck with {} thresholds", self.thresholds.len())
+    }
+}

src/checks/gas.rs

@@ -1,3 +1,5 @@
+use std::fmt::Display;
+
 use crate::shared::alert::Metadata;
 
 use super::{AppConfig, CheckTrait};
@@ -49,6 +51,16 @@ impl CheckTrait for GasCheck {
     }
 }
 
+impl Display for GasCheck {
+    fn fmt(&self, f: &mut std::fmt::Formatter<'_>) -> std::fmt::Result {
+        write!(
+            f,
+            "GasCheck(gas_limit_threshold: {})",
+            self.gas_limit_threshold
+        )
+    }
+}
+
 impl GasCheck {
     pub fn new(config: &AppConfig) -> Self {
         let config = config.get_config();

src/checks/halt.rs

@@ -1,4 +1,7 @@
-use std::time::{Duration, SystemTime, UNIX_EPOCH};
+use std::{
+    fmt::Display,
+    time::{Duration, SystemTime, UNIX_EPOCH},
+};
 
 use crate::shared::alert::{Alert, Metadata, Severity};
 
@@ -93,6 +96,16 @@ impl CheckTrait for HaltCheck {
     }
 }
 
+impl Display for HaltCheck {
+    fn fmt(&self, f: &mut std::fmt::Formatter<'_>) -> std::fmt::Result {
+        write!(
+            f,
+            "HaltCheck(estimated_block_time: {}, halt_threshold: {})",
+            self.estimated_block_time, self.halt_threshold
+        )
+    }
+}
+
 impl HaltCheck {
     pub fn new(config: &AppConfig) -> Self {
         let config = config.get_config();

src/checks/ibc.rs

@@ -1,3 +1,4 @@
+use std::fmt::Display;
 use std::str::FromStr;
 use std::time::Duration;
 
@@ -140,6 +141,12 @@ impl CheckTrait for IbcCheck {
     }
 }
 
+impl Display for IbcCheck {
+    fn fmt(&self, f: &mut std::fmt::Formatter<'_>) -> std::fmt::Result {
+        write!(f, "IbcCheck with {} channels", self.channels.len())
+    }
+}
+
 impl IbcCheck {
     pub fn new(config: &AppConfig) -> Self {
         let channels = config

src/checks/ibc_limit.rs

@@ -1,3 +1,5 @@
+use std::fmt::Display;
+
 use super::CheckTrait;
 
 const LIMIT_IBC_CHECK_ID: &str = "ibc_limit_check";
@@ -44,3 +46,9 @@ impl CheckTrait for IbcLimitCheck {
         false
     }
 }
+
+impl Display for IbcLimitCheck {
+    fn fmt(&self, f: &mut std::fmt::Formatter<'_>) -> std::fmt::Result {
+        write!(f, "IbcLimitCheck")
+    }
+}

src/checks/mod.rs

@@ -9,21 +9,23 @@ mod slashes;
 mod transfer_limit;
 mod tx;
 
+use std::fmt::Display;
+
 use async_trait::async_trait;
-use halt::HaltCheck;
 
 pub use crate::config::AppConfig;
 pub use crate::state::State;
 use crate::{
     checks::{
-        block::BlockCheck, fees::FeeCheck, gas::GasCheck, ibc::IbcCheck, ibc_limit::IbcLimitCheck,
-        pos::PoSCheck, slashes::SlashCheck, transfer_limit::TransferLimitCheck, tx::TxCheck,
+        block::BlockCheck, fees::FeeCheck, gas::GasCheck, halt::HaltCheck, ibc::IbcCheck,
+        ibc_limit::IbcLimitCheck, pos::PoSCheck, slashes::SlashCheck,
+        transfer_limit::TransferLimitCheck, tx::TxCheck,
     },
     shared::alert::Alert,
 };
 
 #[async_trait]
-pub trait CheckTrait: Send + Sync {
+pub trait CheckTrait: Send + Sync + Display {
     async fn check(&self, state: &State) -> Vec<Alert>;
     fn is_continous(&self) -> bool;
 }
@@ -69,4 +71,17 @@ impl CheckManager {
         }
         results
     }
+
+    pub fn get_checks(&self) -> &Vec<Box<dyn CheckTrait>> {
+        &self.checks
+    }
+}
+
+impl Display for CheckManager {
+    fn fmt(&self, f: &mut std::fmt::Formatter<'_>) -> std::fmt::Result {
+        for check in &self.checks {
+            write!(f, "{}", check)?;
+        }
+        write!(f, "CheckManager with {} checks", self.checks.len())
+    }
 }

src/checks/pos.rs

@@ -1,4 +1,4 @@
-use std::time::Duration;
+use std::{fmt::Display, time::Duration};
 
 use super::{AppConfig, CheckTrait};
 
@@ -178,3 +178,18 @@ impl CheckTrait for PoSCheck {
         false
     }
 }
+
+impl Display for PoSCheck {
+    fn fmt(&self, f: &mut std::fmt::Formatter<'_>) -> std::fmt::Result {
+        write!(
+            f,
+            "PoSCheck(mininimum_one_third_validators: {}, mininimum_two_third_validators: {}, bond_increase_threshold: {}, unbond_increase_threshold: {}, consensus_threshold: {}, threshold_missed_votes: {})",
+            self.mininimum_one_third_validators,
+            self.mininimum_two_third_validators,
+            self.bond_increase_threshold,
+            self.unbond_increase_threshold,
+            self.consensus_threshold,
+            self.threshold_missed_votes
+        )
+    }
+}

src/checks/slashes.rs

@@ -1,3 +1,5 @@
+use std::fmt::Display;
+
 use namada_sdk::tendermint::evidence;
 
 use crate::{
@@ -89,3 +91,9 @@ impl CheckTrait for SlashCheck {
         false
     }
 }
+
+impl Display for SlashCheck {
+    fn fmt(&self, f: &mut std::fmt::Formatter<'_>) -> std::fmt::Result {
+        write!(f, "SlashCheck")
+    }
+}