chore(ilc/server): update fastify to v3

Author: stas-nc

ilc/package-lock.json

@@ -20,6 +20,7 @@
     "author": "",
     "license": "Apache-2.0",
     "dependencies": {
+        "@fastify/express": "^1.1.0",
         "@namecheap/error-extender": "^2.2.1",
         "@namecheap/tailorx": "^8.2.1",
         "@newrelic/native-metrics": "^12.0.0",
@@ -32,7 +33,7 @@
         "deepmerge": "4.3.1",
         "eventemitter3": "^5.0.1",
         "exponential-backoff": "^3.1.3",
-        "fastify": "^2.15.3",
+        "fastify": "^3.29.5",
         "http-status-codes": "^2.3.0",
         "ilc-plugins-sdk": "^2.3.0",
         "ilc-sdk": "^6.1.1",
@@ -58,6 +59,7 @@
         "@babel/preset-typescript": "^7.28.5",
         "@types/chai": "^5.2.3",
         "@types/config": "^3.3.5",
+        "@types/express": "^5.0.6",
         "@types/mocha": "^10.0.10",
         "@types/newrelic": "^9.14.8",
         "@types/node": "^22.19.2",

ilc/package.json

@@ -48,7 +48,7 @@ describe('TransitionHooksExecutor', () => {
             pluginManager.getTransitionHooksPlugin.returns(transitionHooksPlugin);
             transitionHooksPlugin.getTransitionHooks.returns(hooks);
 
-            const app = createApp(helpers.getRegistryMock(), pluginManager, context);
+            const app = await createApp(helpers.getRegistryMock(), pluginManager, context);
 
             try {
                 res = await app.inject({ method: 'GET', url: '/all' });
@@ -73,7 +73,7 @@ describe('TransitionHooksExecutor', () => {
             pluginManager.getTransitionHooksPlugin.returns(transitionHooksPlugin);
             transitionHooksPlugin.getTransitionHooks.returns(hooks);
 
-            const app = createApp(helpers.getRegistryMock(), pluginManager, context);
+            const app = await createApp(helpers.getRegistryMock(), pluginManager, context);
 
             try {
                 res = await app.inject({ method: 'GET', url: '/all' });
@@ -96,7 +96,7 @@ describe('TransitionHooksExecutor', () => {
             pluginManager.getTransitionHooksPlugin.returns(transitionHooksPlugin);
             transitionHooksPlugin.getTransitionHooks.returns(hooks);
 
-            const app = createApp(helpers.getRegistryMock(), pluginManager, context);
+            const app = await createApp(helpers.getRegistryMock(), pluginManager, context);
 
             try {
                 res = await app.inject({ method: 'GET', url: '/all' });

ilc/server/TransitionHooksExecutor.spec.js

@@ -1,7 +1,6 @@
 import { PluginManager, TransitionHooksPlugin } from 'ilc-plugins-sdk';
 import { TransitionHookError } from '../common/transition-hooks/errors';
-import { FastifyRequest } from 'fastify';
-import { PatchedHttpRequest } from './types/PatchedHttpRequest';
+import { PatchedFastifyRequest } from './types/PatchedHttpRequest';
 
 type TransitionResult = {
     location: string;
@@ -15,7 +14,7 @@ export class TransitionHooksExecutor {
         this.transitionHooksPlugin = pluginManager.getTransitionHooksPlugin();
     }
 
-    async redirectTo(req: FastifyRequest<PatchedHttpRequest>): Promise<TransitionResult | null> {
+    async redirectTo(req: PatchedFastifyRequest): Promise<TransitionResult | null> {
         if (!req.raw.router) {
             throw new Error('Router not initialized');
         }

ilc/server/TransitionHooksExecutor.ts

@@ -1,5 +1,6 @@
 import config from 'config';
 import fastify from 'fastify';
+import { fastifyExpress } from '@fastify/express';
 import { AsyncResource } from 'node:async_hooks';
 import { errorHandlerFactory } from './errorHandler/factory';
 import { pingPluginFactroy } from './routes/pingPluginFactory';
@@ -19,13 +20,14 @@ const { isStaticFile, isHealthCheck, isDataUri } = require('./utils/utils');
 /**
  * @param {Registry} registryService
  */
-module.exports = (registryService, pluginManager, context) => {
+module.exports = async function createApplication(registryService, pluginManager, context) {
     const reportingPlugin = reportingPluginManager.getInstance();
     const errorHandler = errorHandlerFactory();
     const appConfig = Application.getConfig(reportingPlugin);
     const logger = reportingPluginManager.getLogger();
     const accessLogger = new AccessLogger(config, logger);
     const app = fastify(appConfig);
+    await app.register(fastifyExpress);
 
     const asyncResourceSymbol = Symbol('asyncResource');
 

ilc/server/app.js

@@ -6,7 +6,7 @@ const { context } = require('./context/context');
 const createApp = require('./app');
 
 async function createTestServer(mockRegistryOptions = {}, mockPluginOptions = {}) {
-    const app = createApp(
+    const app = await createApp(
         helpers.getRegistryMock(mockRegistryOptions),
         helpers.getPluginManagerMock(mockPluginOptions),
         context,

ilc/server/app.spec.js

@@ -15,7 +15,7 @@ module.exports = {
             const store = new Map();
 
             store.set('url', request.raw.url);
-            store.set('protocol', request.raw.connection.encrypted ? 'https' : 'http');
+            store.set('protocol', request.raw.socket.encrypted ? 'https' : 'http');
             store.set('path', parsedUrl.pathname);
             store.set('domain', request.hostname);
             store.set('requestId', requestId);

ilc/server/context/context.js

@@ -38,7 +38,7 @@ describe('ErrorHandler', () => {
     });
 
     beforeEach(async () => {
-        app = createApp(
+        app = await createApp(
             helpers.getRegistryMock() as unknown as Registry,
             helpers.getPluginManagerMock() as unknown as PluginManager,
             context,

ilc/server/errorHandler/ErrorHandler.spec.ts

@@ -70,13 +70,13 @@ export default class ErrorHandler {
         // This handler serves as Fastify & Tailor handler.
         // While Fastify will pass it's own Reply object
         // Tailor passes http.ServerResponse from Node core
-        let nres: ServerResponse;
+        let rawResponse: ServerResponse;
         if (isFastifyReply(res)) {
-            nres = res.res;
+            rawResponse = res.raw;
             // Claim full responsibility of the low-level response from Fastify
-            res.sent = true;
+            res.hijack();
         } else {
-            nres = res as ServerResponse;
+            rawResponse = res as ServerResponse;
         }
 
         try {
@@ -87,24 +87,24 @@ export default class ErrorHandler {
             let data = await this.registryService.getTemplate('500', { locale, forDomain: currentDomain });
             const content = data.data.content.replace('%ERRORID%', `Error ID: ${errorId}`);
 
-            this.ensureInternalErrorHeaders(nres, StatusCodes.INTERNAL_SERVER_ERROR);
-            nres.write(content);
-            nres.end();
+            this.ensureInternalErrorHeaders(rawResponse, StatusCodes.INTERNAL_SERVER_ERROR);
+            rawResponse.write(content);
+            rawResponse.end();
         } catch (causeErr) {
             const handlingError = new ErrorHandlingError({
                 message: 'Additional error in error handling',
                 cause: causeErr as Error,
                 data: { errorId, originalError: safeJsonStringify(err) },
             });
             this.logger.error(handlingError);
-            this.writeStaticError(nres);
+            this.writeStaticError(rawResponse);
         }
     }
 
     async handleClientError(reply: ServerResponseFastifyReply, error: Error, statusCode?: number): Promise<void> {
         this.logger.warn(error);
-        reply.sent = true;
-        this.writeStaticError(reply.res!, statusCode);
+        reply.hijack();
+        this.writeStaticError(reply.raw, statusCode);
     }
 
     private ensureInternalErrorHeaders(nres: ServerResponse, statusCode: number): void {

ilc/server/errorHandler/ErrorHandler.ts

@@ -73,7 +73,7 @@ const onRequestFactory =
         const encodedNextI18nCookie = i18nCookie.encode(pluginProcessedI18nConfig);
 
         if (encodedI18nCookie !== encodedNextI18nCookie) {
-            reply.res.setHeader(
+            reply.raw.setHeader(
                 'Set-Cookie',
                 Cookie.serialize(i18nCookie.name, encodedNextI18nCookie, i18nCookie.getOpts()),
             );