Skip to content

Commit d9be88b

Browse files
committed
chore(ilc): update dependencies
1 parent 2ab6360 commit d9be88b

File tree

10 files changed

+230
-173
lines changed

10 files changed

+230
-173
lines changed

.github/workflows/ci.yml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -3,7 +3,7 @@ name: CI
33
on:
44
push:
55
branches:
6-
- master
6+
- '**'
77
tags-ignore:
88
- '**'
99
pull_request:

ilc/Dockerfile

Lines changed: 4 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -1,15 +1,13 @@
1-
FROM node:20.8.0-alpine
1+
FROM node:22-alpine
22

33
RUN apk update && apk add --no-cache bash git openssh python3 make g++ findutils
44

5-
# Legacy infrastructure support
6-
RUN npm install -g stdout-mq@^2.4.0
7-
85
WORKDIR /codebase
96

107
COPY package-lock.json package.json /codebase/
11-
RUN npm ci --no-package-lock --ignore-scripts
12-
RUN npm rebuild @newrelic/native-metrics
8+
RUN npm ci --prefer-offline --no-fund
9+
# Integrity check. Package @newrelic/native-metrics is an optional dependency and may be not installed on alpine
10+
RUN npm ls @newrelic/native-metrics
1311

1412
COPY ./ /codebase
1513

ilc/client/navigationEvents/setupEvents.spec.js

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -2,6 +2,7 @@ import * as chai from 'chai';
22
import sinon from 'sinon';
33
import ilcEvents from '../constants/ilcEvents';
44

5+
import * as singleSpa from 'single-spa';
56
import {
67
addNavigationHook,
78
removeNavigationHook,
@@ -17,6 +18,7 @@ describe('setupEvents', () => {
1718
before(() => {
1819
window.addEventListener(ilcEvents.BEFORE_ROUTING, beforeRoutingEventHandler);
1920
window.addEventListener('popstate', popstateEventHandler);
21+
singleSpa.start();
2022
});
2123

2224
beforeEach(() => {

ilc/client/registerSpaApps.spec.ts

Lines changed: 1 addition & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -104,13 +104,7 @@ describe('registerSpaApps', () => {
104104
afterEach(async () => {
105105
// Unload all registered apps from single-spa to avoid conflicts with other tests
106106
const registeredApps = singleSpa.getAppNames();
107-
await Promise.all(
108-
registeredApps.map((appName) =>
109-
(singleSpa as any).unloadApplication(appName).catch(() => {
110-
// Ignore errors if app is not loaded
111-
}),
112-
),
113-
);
107+
await Promise.all(registeredApps.map((appName) => singleSpa.unloadApplication(appName)));
114108

115109
// Restore stubs
116110
composeAppSlotPairsStub.restore();

0 commit comments

Comments
 (0)