[#84] fixed close of closed channel. (#86)

nandagopalan · web-flow · commit 1eeb036adc12 · 2025-01-15T00:09:03.000+11:00
diff --git a/lifecycle/simple_component.go b/lifecycle/simple_component.go
@@ -212,7 +212,12 @@ func (scm *SimpleComponentManager) StopAll() error {
 		}
 	}
 	wg.Wait()
-	close(scm.waitChan)
+	select {
+	case <-scm.waitChan:
+		logger.Info("All components stopped")
+	default:
+		close(scm.waitChan)
+	}
 	if err.HasErrors() {
 		return err
 	} else {

Original file line number	Diff line number	Diff line change
`@@ -212,7 +212,12 @@ func (scm *SimpleComponentManager) StopAll() error {`
`212`	`212`	`}`
`213`	`213`	`}`
`214`	`214`	`wg.Wait()`
`215`		`- close(scm.waitChan)`
	`215`	`+ select {`
	`216`	`+ case <-scm.waitChan:`
	`217`	`+ logger.Info("All components stopped")`
	`218`	`+ default:`
	`219`	`+ close(scm.waitChan)`
	`220`	`+ }`
`216`	`221`	`if err.HasErrors() {`
`217`	`222`	`return err`
`218`	`223`	`} else {`