[#genai] bug fixes

Author: nandagopalan

genai/message.go

@@ -18,6 +18,26 @@ type Message struct {
 	done     bool
 }
 
+func NewTextMessage(text string, mimeType string) *Message {
+	return &Message{
+		rwer:     bytes.NewBufferString(text),
+		mimeType: mimeType,
+	}
+}
+
+func NewBinMessage(data []byte, mimeType string) *Message {
+	return &Message{
+		rwer:     bytes.NewBuffer(data),
+		mimeType: mimeType,
+	}
+}
+func NewFileMessage(u string, mimeType string) *Message {
+	return &Message{
+		u:        &url.URL{Path: u},
+		mimeType: mimeType,
+	}
+}
+
 // Mime returns the MIME type of the message
 
 func (m *Message) Mime() string {
@@ -34,6 +54,11 @@ func (m *Message) Read(p []byte) (n int, err error) {
 	return m.rwer.Read(p)
 }
 
+// ReadFrom implements the io.ReaderFrom interface
+func (m *Message) ReadFrom(r io.Reader) (n int64, err error) {
+	return io.Copy(m.rwer, r)
+}
+
 // SetActor sets the actor that sent the message
 func (m *Message) SetActor(actor Actor) {
 	m.msgActor = actor
@@ -49,6 +74,10 @@ func (m *Message) Write(p []byte) (n int, err error) {
 	return m.rwer.Write(p)
 }
 
+func (m *Message) WriteTo(w io.Writer) (n int64, err error) {
+	return io.Copy(w, m.rwer)
+}
+
 // URL returns the URL of the message message
 func (b *Message) URL() *url.URL {
 	return b.u
@@ -68,7 +97,15 @@ func (m *Message) Done() {
 func (m *Message) String() string {
 
 	switch m.mimeType {
-	case ioutils.MimeTextPlain, ioutils.MimeTextHTML, ioutils.MimeMarkDown, ioutils.MimeTextYAML:
+	case ioutils.MimeTextPlain,
+		ioutils.MimeTextHTML,
+		ioutils.MimeMarkDown,
+		ioutils.MimeTextYAML,
+		ioutils.MimeApplicationJSON,
+		ioutils.MimeApplicationXML,
+		ioutils.MimeTextXML,
+		ioutils.MimeTextCSS,
+		ioutils.MimeTextCSV:
 		return m.rwer.(*bytes.Buffer).String()
 	default:
 		return fmt.Sprintf("{mimeType: %s, actor: %s}", m.mimeType, m.msgActor)

genai/provider.go

@@ -32,7 +32,7 @@ var GetUnsupportedProviderErr = errutils.NewCustomError("unsupported provider fo
 
 var Providers managers.ItemManager[Provider] = managers.NewItemManager[Provider]()
 
-type StreamingHandller func(message Message, last bool)
+type StreamingHandller func(last bool, messages ...*Message)
 
 type Model struct {
 	Id       string         `json:"id" yaml:"id" bson:"id"`
@@ -68,8 +68,8 @@ type Provider interface {
 	// This will be a non-blocking call.
 	// The handler function will be called for each message generated by the model.
 	// The last parameter will be true for the last message.
-	// The exchange will also be updated with the generated messages.
-	GenerateStream(model string, exchange Exchange, handler StreamingHandller, options Options) error
+	// The exchange will also be updated with the generated messages once the stream is completed successfully.
+	GenerateStream(model string, exchange Exchange, handler StreamingHandller, options *Options) error
 }
 
 // Options represents the options for the Service
@@ -277,9 +277,9 @@ func (o *Options) GetTemperature(defaultValue float32) float32 {
 
 // GetTopP retrieves the "top_p" option from the Options.
 // Returns the value as a float64, or the provided default value if the option does not exist.
-func (o *Options) GetTopP(defaultValue float64) float64 {
+func (o *Options) GetTopP(defaultValue float32) float32 {
 	if o.Has(OptionTopP) {
-		return o.GetFloat64(OptionTopP)
+		return o.GetFloat32(OptionTopP)
 	}
 	return defaultValue
 }