fix: resource resolution (#160)

Author: nank1ro

packages/flutter_solidart/lib/src/widgets/signal_builder.dart

@@ -90,13 +90,11 @@ class _SignalBuilderElement extends StatelessElement {
     try {
       final built = super.build();
       if (SolidartConfig.assertSignalBuilderWithoutDependencies) {
-        assert(
-          node.deps != null,
-          '''
-          SignalBuilder must detect at least one Signal/Computed/Resource during build.
-          You can disable this check by setting `SolidartConfig.assertSignalBuilderWithoutDependencies = false` before `runApp()`'
-          ''',
-        );
+        assert(node.deps != null, '''
+SignalBuilder must detect at least one Signal, Computed, or Resource during the build.
+This may mean your reactive values were disposed. 
+You can disable this check by setting `SolidartConfig.assertSignalBuilderWithoutDependencies = false` before `runApp()`'
+          ''');
       }
       // ignore: invalid_use_of_internal_member
       effect.setDependencies(node);

packages/flutter_solidart/test/flutter_solidart_test.dart

@@ -916,8 +916,12 @@ void main() {
       tester.takeException(),
       isAssertionError.having(
         (error) => error.message,
-        'SignalBuilder must detect at least one Signal/Computed during build.',
-        contains('SignalBuilder must detect at least one Signal/Computed'),
+        '''
+SignalBuilder must detect at least one Signal, Computed, or Resource during the build.
+''',
+        contains(
+          '''SignalBuilder must detect at least one Signal, Computed, or Resource during the build.''',
+        ),
       ),
     );
   });

packages/solidart/CHANGELOG.md

@@ -1,3 +1,7 @@
+## 2.8.3
+
+- **FIX**: Handle race conditions in Resource that caused multiple calls to `resolve`.
+
 ## 2.8.2
 
 - **REFACTOR**: Improve the Solidart DevTools extension by giving any signal an id and omit overriding the same signal by name.

packages/solidart/lib/src/core/reactive_system.dart

@@ -27,10 +27,7 @@ extension MayDisposeDependencies on alien.ReactiveNode {
 }
 
 typedef ReactionErrorHandler =
-    void Function(
-      Object error,
-      ReactionInterface reaction,
-    );
+    void Function(Object error, ReactionInterface reaction);
 
 class ReactiveName {
   ReactiveName._internal();
@@ -166,6 +163,7 @@ class ReactiveSystem extends alien.ReactiveSystem {
   void run(alien.ReactiveNode effect, int flags) {
     if ((flags & 16 /* Dirty */ ) != 0 ||
         ((flags & 32 /* Pending */ ) != 0 &&
+            effect.deps != null &&
             checkDirty(effect.deps!, effect))) {
       final prevSub = setCurrentSub(effect);
       startTracking(effect);

packages/solidart/lib/src/core/resource.dart

@@ -132,7 +132,7 @@ class Resource<T> extends Signal<ResourceState<T>> {
          comparator: identical,
        ) {
     // resolve the resource immediately if not lazy
-    if (!lazy) _resolve();
+    if (!lazy) _resolveIfNeeded();
   }
 
   /// {@macro resource}
@@ -171,7 +171,7 @@ class Resource<T> extends Signal<ResourceState<T>> {
          comparator: identical,
        ) {
     // resolve the resource immediately if not lazy
-    if (!lazy) _resolve();
+    if (!lazy) _resolveIfNeeded();
   }
 
   /// Indicates whether the resource should be computed lazily, defaults to true
@@ -302,7 +302,6 @@ class Resource<T> extends Signal<ResourceState<T>> {
       """The resource has been already resolved, you can't resolve it more than once. Use `refresh()` instead if you want to refresh the value.""",
     );
     _resolved = true;
-
     if (fetcher != null) {
       // start fetching
       await _fetch();

packages/solidart/pubspec.yaml

@@ -1,6 +1,6 @@
 name: solidart
 description: A simple State Management solution for Dart applications inspired by SolidJS
-version: 2.8.2
+version: 2.8.3
 repository: https://github.com/nank1ro/solidart
 documentation: https://solidart.mariuti.com
 topics: