fix(download-progress): only calculate ETA when seconds is finite number

devinus · devinus · commit 3e0cb2b86247 · 2019-01-28T00:17:15.000-06:00
diff --git a/app/components/download-progress/component.js b/app/components/download-progress/component.js
@@ -97,9 +97,11 @@ export default class DownloadProgressComponent extends Component.extend(
   updateProgress(value) {
     const delta = value - this.get('value');
     const speed = this.speed(delta);
-    const remaining = 1 - value;
+    const remaining = Math.max(0, 1 - value);
     const seconds = Math.round(remaining / speed);
-    const eta = moment().add(seconds, 'second').toDate();
+    const eta = Number.isFinite(seconds)
+      ? moment().add(seconds, 'second').toDate()
+      : null;
     this.setProperties({ value, eta });
   }
 }

Original file line number	Diff line number	Diff line change
`@@ -97,9 +97,11 @@ export default class DownloadProgressComponent extends Component.extend(`
`97`	`97`	`updateProgress(value) {`
`98`	`98`	`const delta = value - this.get('value');`
`99`	`99`	`const speed = this.speed(delta);`
`100`		`- const remaining = 1 - value;`
	`100`	`+ const remaining = Math.max(0, 1 - value);`
`101`	`101`	`const seconds = Math.round(remaining / speed);`
`102`		`- const eta = moment().add(seconds, 'second').toDate();`
	`102`	`+ const eta = Number.isFinite(seconds)`
	`103`	`+ ? moment().add(seconds, 'second').toDate()`
	`104`	`+ : null;`
`103`	`105`	`this.setProperties({ value, eta });`
`104`	`106`	`}`
`105`	`107`	`}`