Skip to content

Commit 9f36ba9

Browse files
committed
* MDF [mqtt/transport] add guard of alloc for review comment
Signed-off-by: Jaylin <jaylin@emqx.io>
1 parent 19bacf1 commit 9f36ba9

File tree

3 files changed

+9
-0
lines changed

3 files changed

+9
-0
lines changed

src/sp/transport/mqtt/broker_tcp.c

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -202,6 +202,9 @@ tcptran_pipe_init(void *arg, nni_pipe *npipe)
202202
nni_lmq_init(&p->rslmq, 16);
203203
p->qos_buf = nng_zalloc(16 + NNI_NANO_MAX_PACKET_SIZE);
204204
p->npipe->subinfol = nni_zalloc(sizeof(nni_list));
205+
if (p->npipe->subinfol == NULL) {
206+
return (NNG_ENOMEM);
207+
}
205208
NNI_LIST_INIT(p->npipe->subinfol, struct subinfo, node);
206209
log_trace(" ************ tcptran_pipe_init [%p] ************ ", p);
207210
return (0);

src/sp/transport/mqtts/broker_tls.c

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -209,6 +209,9 @@ tlstran_pipe_init(void *arg, nni_pipe *npipe)
209209
nni_atomic_init_bool(&p->closed);
210210
p->qos_buf = nng_zalloc(16 + NNI_NANO_MAX_PACKET_SIZE);
211211
p->npipe->subinfol = nni_zalloc(sizeof(nni_list));
212+
if (p->npipe->subinfol == NULL) {
213+
return (NNG_ENOMEM);
214+
}
212215
NNI_LIST_INIT(p->npipe->subinfol, struct subinfo, node);
213216
log_trace(" ************ tlstran_pipe_init [%p] ************ ", p);
214217
return (0);

src/sp/transport/mqttws/nmq_websocket.c

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1176,6 +1176,9 @@ wstran_pipe_init(void *arg, nni_pipe *pipe)
11761176

11771177
p->qos_buf = nng_zalloc(16 + NNI_NANO_MAX_PACKET_SIZE);
11781178
p->npipe->subinfol = nni_zalloc(sizeof(nni_list));
1179+
if (p->npipe->subinfol == NULL) {
1180+
return (NNG_ENOMEM);
1181+
}
11791182
NNI_LIST_INIT(p->npipe->subinfol, struct subinfo, node);
11801183
nni_lmq_init(&p->recvlmq, 1024);
11811184
nni_lmq_init(&p->rslmq, 1024);

0 commit comments

Comments
 (0)