fix(xds): resolve golangci-lint issues in delta xDS code #354
mahmut-Abici.yml
on: push
go-build
1m 6s
go-test
2m 6s
go-test-race
2m 50s
go-lint
3m 24s
proto-check
19s
go-bench
3m 6s
Annotations
12 errors and 2 warnings
|
go-test-race
Process completed with exit code 1.
|
|
go-bench
auto-push must be false when external-data-json-path is set since this action reads/writes the given JSON file and never pushes to remote
|
|
go-lint:
internal/admin/auth_test.go#L43
string `/livez` has 6 occurrences, make it a constant (goconst)
|
|
go-lint:
internal/admin/auth_test.go#L16
string `abc123` has 4 occurrences, make it a constant (goconst)
|
|
go-lint:
internal/admin/auth.go#L501
string `/livez` has 6 occurrences, make it a constant (goconst)
|
|
go-lint:
internal/admin/admin_benchmark_test.go#L266
string `service` has 19 occurrences, make it a constant (goconst)
|
|
go-lint:
internal/admin/admin_benchmark_test.go#L245
string `GRPC` has 11 occurrences, make it a constant (goconst)
|
|
go-lint:
internal/admin/admin_benchmark_test.go#L91
string `default` has 70 occurrences, make it a constant (goconst)
|
|
go-lint:
internal/admin/admin_benchmark_test.go#L90
string `HTTPRoute` has 13 occurrences, make it a constant (goconst)
|
|
go-lint:
internal/admin/admin_benchmark_test.go#L60
string `protocol` has 4 occurrences, but such constant `listenerSortByProtocol` already exists (goconst)
|
|
go-lint:
internal/admin/admin_benchmark_test.go#L32
string `name` has 6 occurrences, but such constant `infrastructureSortByName` already exists (goconst)
|
|
go-lint:
internal/admin/admin_benchmark_test.go#L31
string `http` has 11 occurrences, make it a constant (goconst)
|
|
proto-check
Generated Go code may be out of date — Buf remote plugin version drift. Verify with 'buf generate ../proto && go mod tidy' locally.
|
|
proto-check
go mod tidy produced changes — run 'go mod tidy' locally.
|