Skip to content

Commit 49e35c3

Browse files
committed
fix(grafana): use ${var} syntax for multi-select template variables
Quoted variable references like pod=~"$pod_dp" don't expand $__all (All) in PromQL. Change to pod=~"${pod_dp}" so Grafana properly expands $__all to .+ when 'All' is selected. Affected: 8 pod_dp, 2 job_controlplane, 1 job_dataplane refs
1 parent 8d375d8 commit 49e35c3

1 file changed

Lines changed: 11 additions & 11 deletions

File tree

deploy/observability/grafana/pingora-gateway-observability-dashboard.json

Lines changed: 11 additions & 11 deletions
Original file line numberDiff line numberDiff line change
@@ -368,7 +368,7 @@
368368
},
369369
"targets": [
370370
{
371-
"expr": "histogram_quantile(0.95, sum(rate(nantian_gateway_controlplane_xds_publish_ack_lag_seconds_bucket{job=~\"$job_controlplane\"}[$__rate_interval])) by (le))",
371+
"expr": "histogram_quantile(0.95, sum(rate(nantian_gateway_controlplane_xds_publish_ack_lag_seconds_bucket{job=~\"${job_controlplane}\"}[$__rate_interval])) by (le))",
372372
"refId": "A"
373373
}
374374
],
@@ -403,7 +403,7 @@
403403
},
404404
"targets": [
405405
{
406-
"expr": "(sum(rate(container_cpu_cfs_throttled_periods_total{namespace=~\"$namespace\",container!=\"\",pod=~\"$pod_dp\"}[$__rate_interval]) / rate(container_cpu_cfs_periods_total{namespace=~\"$namespace\",container!=\"\",pod=~\"$pod_dp\"}[$__rate_interval]))) or vector(0)",
406+
"expr": "(sum(rate(container_cpu_cfs_throttled_periods_total{namespace=~\"$namespace\",container!=\"\",pod=~\"${pod_dp}\"}[$__rate_interval]) / rate(container_cpu_cfs_periods_total{namespace=~\"$namespace\",container!=\"\",pod=~\"${pod_dp}\"}[$__rate_interval]))) or vector(0)",
407407
"refId": "A"
408408
}
409409
],
@@ -438,7 +438,7 @@
438438
},
439439
"targets": [
440440
{
441-
"expr": "sum(container_memory_working_set_bytes{namespace=~\"$namespace\",container!=\"\",pod=~\"$pod_dp\"})",
441+
"expr": "sum(container_memory_working_set_bytes{namespace=~\"$namespace\",container!=\"\",pod=~\"${pod_dp}\"})",
442442
"refId": "A"
443443
}
444444
],
@@ -857,7 +857,7 @@
857857
},
858858
"targets": [
859859
{
860-
"expr": "sum(nantian_gateway_dataplane_traffic_failover_success_rate{job=~\"$job_dataplane\"}) or vector(0)",
860+
"expr": "sum(nantian_gateway_dataplane_traffic_failover_success_rate{job=~\"${job_dataplane}\"}) or vector(0)",
861861
"refId": "A"
862862
}
863863
],
@@ -1211,12 +1211,12 @@
12111211
"options": {},
12121212
"targets": [
12131213
{
1214-
"expr": "rate(container_cpu_usage_seconds_total{namespace=~\"$namespace\",container!=\"\",pod=~\"$pod_dp\"}[$__rate_interval])",
1214+
"expr": "rate(container_cpu_usage_seconds_total{namespace=~\"$namespace\",container!=\"\",pod=~\"${pod_dp}\"}[$__rate_interval])",
12151215
"legendFormat": "cores",
12161216
"refId": "A"
12171217
},
12181218
{
1219-
"expr": "avg by (pod) (kube_pod_container_resource_requests{namespace=~\"$namespace\",container!=\"\",pod=~\"$pod_dp\",resource=\"cpu\"})",
1219+
"expr": "avg by (pod) (kube_pod_container_resource_requests{namespace=~\"$namespace\",container!=\"\",pod=~\"${pod_dp}\",resource=\"cpu\"})",
12201220
"legendFormat": "request",
12211221
"refId": "B"
12221222
}
@@ -1244,7 +1244,7 @@
12441244
"options": {},
12451245
"targets": [
12461246
{
1247-
"expr": "(rate(container_cpu_cfs_throttled_periods_total{namespace=~\"$namespace\",container!=\"\",pod=~\"$pod_dp\"}[$__rate_interval]) / rate(container_cpu_cfs_periods_total{namespace=~\"$namespace\",container!=\"\",pod=~\"$pod_dp\"}[$__rate_interval])) or vector(0)",
1247+
"expr": "(rate(container_cpu_cfs_throttled_periods_total{namespace=~\"$namespace\",container!=\"\",pod=~\"${pod_dp}\"}[$__rate_interval]) / rate(container_cpu_cfs_periods_total{namespace=~\"$namespace\",container!=\"\",pod=~\"${pod_dp}\"}[$__rate_interval])) or vector(0)",
12481248
"legendFormat": "throttle",
12491249
"refId": "A"
12501250
}
@@ -1272,17 +1272,17 @@
12721272
"options": {},
12731273
"targets": [
12741274
{
1275-
"expr": "sum by (pod) (container_memory_working_set_bytes{namespace=~\"$namespace\",container!=\"\",pod=~\"$pod_dp\"})",
1275+
"expr": "sum by (pod) (container_memory_working_set_bytes{namespace=~\"$namespace\",container!=\"\",pod=~\"${pod_dp}\"})",
12761276
"legendFormat": "{{pod}}",
12771277
"refId": "A"
12781278
},
12791279
{
1280-
"expr": "avg by (pod) (kube_pod_container_resource_limits{namespace=~\"$namespace\",container!=\"\",pod=~\"$pod_dp\",resource=\"memory\"})",
1280+
"expr": "avg by (pod) (kube_pod_container_resource_limits{namespace=~\"$namespace\",container!=\"\",pod=~\"${pod_dp}\",resource=\"memory\"})",
12811281
"legendFormat": "limit",
12821282
"refId": "B"
12831283
},
12841284
{
1285-
"expr": "avg by (pod) (kube_pod_container_resource_requests{namespace=~\"$namespace\",container!=\"\",pod=~\"$pod_dp\",resource=\"memory\"})",
1285+
"expr": "avg by (pod) (kube_pod_container_resource_requests{namespace=~\"$namespace\",container!=\"\",pod=~\"${pod_dp}\",resource=\"memory\"})",
12861286
"legendFormat": "request",
12871287
"refId": "C"
12881288
}
@@ -1498,7 +1498,7 @@
14981498
"options": {},
14991499
"targets": [
15001500
{
1501-
"expr": "histogram_quantile(0.99, sum(rate(nantian_gateway_controlplane_xds_publish_ack_lag_seconds_bucket{job=~\"$job_controlplane\"}[$__rate_interval])) by (le))",
1501+
"expr": "histogram_quantile(0.99, sum(rate(nantian_gateway_controlplane_xds_publish_ack_lag_seconds_bucket{job=~\"${job_controlplane}\"}[$__rate_interval])) by (le))",
15021502
"legendFormat": "ACK p99",
15031503
"refId": "A"
15041504
}

0 commit comments

Comments
 (0)