Skip to content

Commit 77ad9cd

Browse files
committed
fix(grafana): convert template variable query objects to strings
The templating.list[].query fields were objects ({query, refId}) instead of plain strings. Newer Grafana versions interpret these objects as React children, causing React error #31 ('Objects are not valid as a React child') and dashboard crash.
1 parent fb3072c commit 77ad9cd

1 file changed

Lines changed: 7 additions & 28 deletions

File tree

deploy/observability/grafana/pingora-gateway-observability-dashboard.json

Lines changed: 7 additions & 28 deletions
Original file line numberDiff line numberDiff line change
@@ -22,21 +22,15 @@
2222
"name": "datasource",
2323
"type": "datasource",
2424
"label": "Prometheus",
25-
"query": {
26-
"query": "prometheus",
27-
"refId": "StandardVariableQuery"
28-
},
25+
"query": "prometheus",
2926
"regex": "",
3027
"refresh": 1
3128
},
3229
{
3330
"name": "namespace",
3431
"type": "query",
3532
"label": "Namespace",
36-
"query": {
37-
"query": "label_values(nantian_gateway_dataplane_ready, namespace)",
38-
"refId": "StandardVariableQuery"
39-
},
33+
"query": "label_values(nantian_gateway_dataplane_ready, namespace)",
4034
"refresh": 1,
4135
"multi": false,
4236
"includeAll": false,
@@ -50,10 +44,7 @@
5044
"name": "pod_dp",
5145
"type": "query",
5246
"label": "Dataplane Pod",
53-
"query": {
54-
"query": "label_values(nantian_gateway_dataplane_ready{namespace=~\"$namespace\"}, pod)",
55-
"refId": "StandardVariableQuery"
56-
},
47+
"query": "label_values(nantian_gateway_dataplane_ready{namespace=~\"$namespace\"}, pod)",
5748
"refresh": 1,
5849
"multi": true,
5950
"includeAll": true,
@@ -67,10 +58,7 @@
6758
"name": "job_controlplane",
6859
"type": "query",
6960
"label": "Control Plane Job",
70-
"query": {
71-
"query": "label_values(nantian_gateway_controlplane_admin_requests_total, job)",
72-
"refId": "StandardVariableQuery"
73-
},
61+
"query": "label_values(nantian_gateway_controlplane_admin_requests_total, job)",
7462
"refresh": 1,
7563
"multi": true,
7664
"includeAll": true,
@@ -83,10 +71,7 @@
8371
"name": "instance_cp",
8472
"type": "query",
8573
"label": "CP Instance",
86-
"query": {
87-
"query": "label_values(nantian_gateway_controlplane_admin_requests_total{job=~\"$job_controlplane\"}, instance)",
88-
"refId": "StandardVariableQuery"
89-
},
74+
"query": "label_values(nantian_gateway_controlplane_admin_requests_total{job=~\"$job_controlplane\"}, instance)",
9075
"refresh": 1,
9176
"multi": true,
9277
"includeAll": true,
@@ -99,10 +84,7 @@
9984
"name": "job_dataplane",
10085
"type": "query",
10186
"label": "Data Plane Job",
102-
"query": {
103-
"query": "label_values(nantian_gateway_dataplane_admin_requests_total, job)",
104-
"refId": "StandardVariableQuery"
105-
},
87+
"query": "label_values(nantian_gateway_dataplane_admin_requests_total, job)",
10688
"refresh": 1,
10789
"multi": true,
10890
"includeAll": true,
@@ -115,10 +97,7 @@
11597
"name": "instance_dp",
11698
"type": "query",
11799
"label": "DP Instance",
118-
"query": {
119-
"query": "label_values(nantian_gateway_dataplane_admin_requests_total{job=~\"$job_dataplane\"}, instance)",
120-
"refId": "StandardVariableQuery"
121-
},
100+
"query": "label_values(nantian_gateway_dataplane_admin_requests_total{job=~\"$job_dataplane\"}, instance)",
122101
"refresh": 1,
123102
"multi": true,
124103
"includeAll": true,

0 commit comments

Comments
 (0)