napalm-automation
diff --git a/‎.github/ISSUE_TEMPLATE‎
Lines changed: 36 additions & 0 deletions b/‎.github/ISSUE_TEMPLATE‎
Lines changed: 36 additions & 0 deletions
diff --git a/‎Dockerfile‎
Lines changed: 7 additions & 12 deletions b/‎Dockerfile‎
Lines changed: 7 additions & 12 deletions
diff --git a/‎docs/contributing/index.rst‎
Lines changed: 24 additions & 1 deletion b/‎docs/contributing/index.rst‎
Lines changed: 24 additions & 1 deletion
diff --git a/‎docs/installation/index.rst‎
Lines changed: 19 additions & 0 deletions b/‎docs/installation/index.rst‎
Lines changed: 19 additions & 0 deletions
diff --git a/‎docs/installation/ios.rst‎
Lines changed: 0 additions & 8 deletions b/‎docs/installation/ios.rst‎
Lines changed: 0 additions & 8 deletions
diff --git a/‎docs/installation/iosxr.rst‎
Lines changed: 0 additions & 8 deletions b/‎docs/installation/iosxr.rst‎
Lines changed: 0 additions & 8 deletions
diff --git a/‎docs/installation/junos.rst‎
Lines changed: 0 additions & 7 deletions b/‎docs/installation/junos.rst‎
Lines changed: 0 additions & 7 deletions
diff --git a/‎docs/validate/index.rst‎
Lines changed: 1 addition & 1 deletion b/‎docs/validate/index.rst‎
Lines changed: 1 addition & 1 deletion
diff --git a/‎napalm/base/base.py‎
Lines changed: 24 additions & 8 deletions b/‎napalm/base/base.py‎
Lines changed: 24 additions & 8 deletions
diff --git a/‎napalm/base/clitools/cl_napalm.py‎
Lines changed: 3 additions & 0 deletions b/‎napalm/base/clitools/cl_napalm.py‎
Lines changed: 3 additions & 0 deletions
@@ -0,0 +1,36 @@
+### Description of Issue/Question
+
+*Note*: Please check https://guides.github.com/features/mastering-markdown/
+to see how to properly format your request.
+
+### Did you follow the steps from https://github.com/napalm-automation/napalm#faq
+(Place an ``x`` between the square brackets where applicable)
+
+- [] Yes
+- [] No
+
+
+### Setup
+
+### napalm version
+(Paste verbatim output from `pip freeze | grep napalm` between quotes below)
+
+```
+
+```
+
+### Network operating system version
+(Paste verbatim output from `show version` - or equivalent - between quotes below)
+
+```
+
+```
+
+### Steps to Reproduce the Issue
+
+### Error Traceback
+(Paste the complete traceback of the exception between quotes below)
+
+```
+
+```
@@ -1,15 +1,10 @@
-FROM debian:stretch
-
-## Install min deps
-RUN apt-get update
+FROM python:3.6-slim-stretch
 
 COPY ./ /var/cache/napalm/
 
-## Install NAPALM & underlying libraries dependencies
-RUN apt-get install -y python-cffi python-dev libxslt1-dev libssl-dev libffi-dev \
-    && apt-get install -y python-pip \
-    && pip install -U cffi \
-    && pip install -U cryptography \
-    && pip install /var/cache/napalm/
-
-RUN rm -rf /var/lib/apt/lists/*
+RUN apt-get update \
+ && apt-get install -y python-dev python-cffi libxslt1-dev libssl-dev libffi-dev \
+ && apt-get autoremove \
+ && rm -rf /var/lib/apt/lists/* \
+ && pip --no-cache-dir install -U cffi cryptography /var/cache/napalm/ \
+ && rm -rf /var/cache/napalm/
@@ -44,7 +44,27 @@ If you found a bug and know how to fix just contribute the bugfix. It might be i
 Documentation
 -------------
 
-Just do it! :)
+The documentation is built using `Sphinx`_ and hosted on Read the Docs. The docs
+are kept in the ``docs/`` directory at the top of the source tree.
+
+To make changes, it is preferable to set up a `python virtual environment`_
+called ``env`` and activate it.
+
+Next, install the documentation dependencies using ``pip``:
+
+.. code:: console
+
+   pip install -r docs/requirements.txt
+
+Make your changes and then check them for correctness by building them locally:
+
+.. code:: console
+
+   # in the docs directory
+   make html
+
+.. tip:: If it is a simple change to a single page, you can use the "Edit on
+   GitHub" button in the upper right hand corner of the page in question.
 
 Proposing a new driver
 ----------------------
@@ -58,3 +78,6 @@ Please check :ref:`contributing-drivers` to understand the process.
 
    core
    drivers
+
+.. _python virtual environment: https://packaging.python.org/guides/installing-using-pip-and-virtualenv/
+.. _Sphinx: http://www.sphinx-doc.org/en/master/
@@ -14,6 +14,25 @@ You can install napalm with pip:
 That will install all the drivers currently available.
 
 
+OS Package Managers
+-------------------
+
+Some execution environments offer napalm through a system-level package manager. Installing with pip outside of a user profile or virtualenv/venv is inadvisable in these cases.
+
+FreeBSD
+~~~~~~~
+
+.. code-block:: bash
+
+    pkg install net-mgmt/py-napalm
+
+This will install napalm and all drivers and dependencies for the default version(s) of python. To install for a specific version, python X.Y, if supported:
+
+.. code-block:: bash
+
+    pkg install pyXY-napalm
+
+
 Dependencies
 ------------
 
 
@@ -15,11 +15,3 @@ RedHat and CentOS
 .. code-block:: bash
 
     sudo yum install -y python-pip gcc openssl openssl-devel libffi-devel python-devel
-
-
-FreeBSD
--------
-
-.. code-block:: bash
-
-    sudo pkg_add -r py27-pip
@@ -15,11 +15,3 @@ RedHat and CentOS
 .. code-block:: bash
 
     sudo yum install -y python-pip gcc openssl openssl-devel libffi-devel python-devel
-
-
-FreeBSD
--------
-
-.. code-block:: bash
-
-    sudo pkg_add -r py27-pip
@@ -15,10 +15,3 @@ RedHat and CentOS
 .. code-block:: bash
 
     sudo yum install -y python-pip python-devel libxml2-devel libxslt-devel gcc openssl openssl-devel libffi-devel
-
-FreeBSD
--------
-
-.. code-block:: bash
-
-    sudo pkg_add -r py27-pip libxml2 libxslt
@@ -263,7 +263,7 @@ CLI & Ansible
 If you prefer, you can also make use of the validate functionality via the CLI with the command ``cl_napalm_validate`` or with ansible plugin. You can find more information about them here:
 
 * CLI - https://github.com/napalm-automation/napalm/pull/168
-* Ansible - https://github.com/napalm-automation/napalm-ansible/blob/master/library/napalm_validate.py
+* Ansible - https://github.com/napalm-automation/napalm-ansible/blob/master/napalm_ansible/modules/napalm_validate.py
 
 
 Why this and what's next
 
@@ -16,14 +16,16 @@
 from __future__ import print_function
 from __future__ import unicode_literals
 
+import sys
+
+from netmiko import ConnectHandler, NetMikoTimeoutException
+
 # local modules
 import napalm.base.exceptions
-from napalm.base.exceptions import ConnectionException
 import napalm.base.helpers
 from napalm.base import constants as c
 from napalm.base import validate
-
-from netmiko import ConnectHandler, NetMikoTimeoutException
+from napalm.base.exceptions import ConnectionException
 
 
 class NetworkDriver(object):
@@ -44,8 +46,15 @@ def __init__(self, hostname, username, password, timeout=60, optional_args=None)
         raise NotImplementedError
 
     def __enter__(self):
-        self.open()
-        return self
+        try:
+            self.open()
+            return self
+        except:  # noqa: E722
+            # Swallow exception if __exit__ returns a True value
+            if self.__exit__(*sys.exc_info()):
+                pass
+            else:
+                raise
 
     def __exit__(self, exc_type, exc_value, exc_traceback):
         self.close()
@@ -95,8 +104,9 @@ def _netmiko_open(self, device_type, netmiko_optional_args=None):
 
     def _netmiko_close(self):
         """Standardized method of closing a Netmiko connection."""
-        self.device.disconnect()
-        self._netmiko_device = None
+        if getattr(self, "_netmiko_device", None):
+            self._netmiko_device.disconnect()
+            self._netmiko_device = None
         self.device = None
 
     def open(self):
@@ -268,6 +278,7 @@ def get_interfaces(self):
          * description (string)
          * last_flapped (float in seconds)
          * speed (int in Mbit)
+         * MTU (in Bytes)
          * mac_address (string)
 
         Example::
@@ -280,6 +291,7 @@ def get_interfaces(self):
                 'description': '',
                 'last_flapped': -1.0,
                 'speed': 1000,
+                'mtu': 1500,
                 'mac_address': 'FA:16:3E:57:33:61',
                 },
             u'Ethernet1':
@@ -289,6 +301,7 @@ def get_interfaces(self):
                 'description': 'foo',
                 'last_flapped': 1429978575.1554043,
                 'speed': 1000,
+                'mtu': 1500,
                 'mac_address': 'FA:16:3E:57:33:62',
                 },
             u'Ethernet2':
@@ -298,6 +311,7 @@ def get_interfaces(self):
                 'description': 'bla',
                 'last_flapped': 1429978575.1555667,
                 'speed': 1000,
+                'mtu': 1500,
                 'mac_address': 'FA:16:3E:57:33:63',
                 },
             u'Ethernet3':
@@ -307,6 +321,7 @@ def get_interfaces(self):
                 'description': 'bar',
                 'last_flapped': -1.0,
                 'speed': 1000,
+                'mtu': 1500,
                 'mac_address': 'FA:16:3E:57:33:64',
                 }
             }
@@ -1497,13 +1512,14 @@ def get_optics(self):
         """
         raise NotImplementedError
 
-    def get_config(self, retrieve="all"):
+    def get_config(self, retrieve="all", full=False):
         """
         Return the configuration of a device.
 
         Args:
             retrieve(string): Which configuration type you want to populate, default is all of them.
                               The rest will be set to "".
+            full(bool): Retrieve all the configuration. For instance, on ios, "sh run all".
 
         Returns:
           The object returned is a dictionary with a key for each configuration store:
 
@@ -146,6 +146,9 @@ def build_help():
     )
     args = parser.parse_args()
 
+    if not hasattr(args, "which"):
+        args.which = None
+
     if args.password is None:
         password = getpass.getpass("Enter password: ")
         setattr(args, "password", password)
Original file line number	Diff line number	Diff line change
`@@ -146,6 +146,9 @@ def build_help():`
`146`	`146`	`)`
`147`	`147`	`args = parser.parse_args()`
`148`	`148`
	`149`	`+ if not hasattr(args, "which"):`
	`150`	`+ args.which = None`
	`151`	`+`
`149`	`152`	`if args.password is None:`
`150`	`153`	`password = getpass.getpass("Enter password: ")`
`151`	`154`	`setattr(args, "password", password)`