fix: resolve clippy warnings across workspace

- Replace manual Default impls with derive macros and #[default] attrs
- Add RgbSamplePatches type alias to reduce type complexity
- Use is_multiple_of() instead of modulo comparison
- Change &PathBuf to &Path in determine_output_path signature
- Remove unnecessary i32 casts in GUI sampling code
- Remove needless borrow in export path handling

🤖 Generated with [Claude Code](https://claude.com/claude-code)

Co-Authored-By: Claude <noreply@anthropic.com>

Author: narrowstacks

crates/invers-cli/src/lib.rs

@@ -3,7 +3,7 @@
 //! This module provides reusable functions and utilities that can be
 //! shared between the CLI and GUI applications.
 
-use std::path::PathBuf;
+use std::path::{Path, PathBuf};
 
 /// Parse ROI string in format "x,y,width,height"
 ///
@@ -51,7 +51,7 @@ pub fn parse_roi(roi_str: &str) -> Result<(u32, u32, u32, u32), String> {
 /// # Returns
 /// The full output path for the converted image
 pub fn determine_output_path(
-    input: &PathBuf,
+    input: &Path,
     out: &Option<PathBuf>,
     export: &str,
 ) -> Result<PathBuf, String> {

crates/invers-core/src/auto_adjust.rs

@@ -6,22 +6,17 @@
 use std::cmp::Ordering;
 
 /// Auto-levels mode for controlling color preservation
-#[derive(Debug, Clone, Copy, PartialEq)]
+#[derive(Debug, Clone, Copy, PartialEq, Default)]
 pub enum AutoLevelsMode {
     /// Independent per-channel stretching (default, may shift colors)
+    #[default]
     PerChannel,
     /// Saturation-aware: reduces stretch for channels that would clip heavily
     SaturationAware,
     /// Preserve saturation: use minimum stretch across all channels
     PreserveSaturation,
 }
 
-impl Default for AutoLevelsMode {
-    fn default() -> Self {
-        Self::PerChannel
-    }
-}
-
 /// Auto-levels: Stretch histogram to full 0.0-1.0 range per channel
 /// This is the key missing step that Photoshop/Grain2Pixel applies
 ///

crates/invers-core/src/config.rs

@@ -25,7 +25,7 @@ impl PipelineConfigHandle {
 }
 
 /// Complete configuration file structure.
-#[derive(Debug, Clone, Deserialize)]
+#[derive(Debug, Clone, Deserialize, Default)]
 #[serde(default)]
 pub struct PipelineConfig {
     pub defaults: PipelineDefaults,
@@ -51,15 +51,6 @@ impl PipelineConfig {
     }
 }
 
-impl Default for PipelineConfig {
-    fn default() -> Self {
-        Self {
-            defaults: PipelineDefaults::default(),
-            testing: TestingConfig::default(),
-        }
-    }
-}
-
 /// Default pipeline parameter values.
 #[derive(Debug, Clone, Deserialize)]
 #[serde(default)]
@@ -132,7 +123,7 @@ impl Default for PipelineDefaults {
 }
 
 /// Testing-related configuration overrides.
-#[derive(Debug, Clone, Deserialize)]
+#[derive(Debug, Clone, Deserialize, Default)]
 #[serde(default)]
 pub struct TestingConfig {
     pub parameter_test_defaults: Option<ParameterTestDefaults>,
@@ -141,17 +132,6 @@ pub struct TestingConfig {
     pub comprehensive_grid: Option<TestingGridValues>,
 }
 
-impl Default for TestingConfig {
-    fn default() -> Self {
-        Self {
-            parameter_test_defaults: None,
-            default_grid: None,
-            minimal_grid: None,
-            comprehensive_grid: None,
-        }
-    }
-}
-
 /// Defaults for a single parameter test run.
 #[derive(Debug, Clone, Deserialize)]
 #[serde(default)]

crates/invers-core/src/diagnostics.rs

@@ -8,6 +8,9 @@ use crate::exporters::export_tiff16;
 use crate::pipeline::ProcessedImage;
 use std::path::Path;
 
+/// RGB sample patches (shadow, midtone, highlight) as flat f32 arrays
+pub type RgbSamplePatches = (Vec<f32>, Vec<f32>, Vec<f32>);
+
 /// Statistics for a single channel
 #[derive(Debug, Clone)]
 pub struct ChannelStats {
@@ -203,7 +206,7 @@ pub fn extract_sample_patches(
     width: u32,
     height: u32,
     patch_size: u32,
-) -> Result<(Vec<f32>, Vec<f32>, Vec<f32>), String> {
+) -> Result<RgbSamplePatches, String> {
     // Find representative regions
     let shadow_center = find_representative_pixel(data, width, height, 0.1, 0.3)?;
     let midtone_center = find_representative_pixel(data, width, height, 0.4, 0.6)?;

crates/invers-core/src/exporters.rs

@@ -82,7 +82,7 @@ pub fn export_linear_dng<P: AsRef<Path>>(
 }
 
 /// Metadata for DNG export
-#[derive(Debug, Clone)]
+#[derive(Debug, Clone, Default)]
 pub struct DngMetadata {
     /// Camera make
     pub make: Option<String>,
@@ -102,16 +102,3 @@ pub struct DngMetadata {
     /// Color matrix
     pub color_matrix: Option<[[f32; 3]; 3]>,
 }
-
-impl Default for DngMetadata {
-    fn default() -> Self {
-        Self {
-            make: None,
-            model: None,
-            black_level: None,
-            white_level: None,
-            as_shot_neutral: None,
-            color_matrix: None,
-        }
-    }
-}

crates/invers-core/src/models.rs

@@ -302,19 +302,21 @@ fn default_auto_exposure_max_gain() -> f32 {
 }
 
 /// Output format options
-#[derive(Debug, Clone, Copy, PartialEq, Eq, Serialize, Deserialize)]
+#[derive(Debug, Clone, Copy, PartialEq, Eq, Serialize, Deserialize, Default)]
 pub enum OutputFormat {
     /// 16-bit linear TIFF
+    #[default]
     Tiff16,
 
     /// Linear DNG
     LinearDng,
 }
 
 /// Bit depth handling policy
-#[derive(Debug, Clone, Copy, PartialEq, Eq, Serialize, Deserialize)]
+#[derive(Debug, Clone, Copy, PartialEq, Eq, Serialize, Deserialize, Default)]
 pub enum BitDepthPolicy {
     /// Match input bit depth when possible
+    #[default]
     MatchInput,
 
     /// Always use 16-bit output
@@ -325,9 +327,10 @@ pub enum BitDepthPolicy {
 }
 
 /// Base estimation sampling mode
-#[derive(Debug, Clone, Copy, PartialEq, Eq, Serialize, Deserialize)]
+#[derive(Debug, Clone, Copy, PartialEq, Eq, Serialize, Deserialize, Default)]
 pub enum BaseSamplingMode {
     /// Use median of brightest pixels (default, robust)
+    #[default]
     Median,
 
     /// Use mean of brightest pixels (more sensitive to maximum)
@@ -338,22 +341,24 @@ pub enum BaseSamplingMode {
 }
 
 /// Inversion mode for negative-to-positive conversion
-#[derive(Debug, Clone, Copy, PartialEq, Eq, Serialize, Deserialize)]
+#[derive(Debug, Clone, Copy, PartialEq, Eq, Serialize, Deserialize, Default)]
 pub enum InversionMode {
     /// Linear inversion: (base - negative) / base
+    #[default]
     Linear,
 
     /// Logarithmic inversion: 10^(log10(base) - log10(negative))
     Logarithmic,
 }
 
 /// Shadow lift mode
-#[derive(Debug, Clone, Copy, PartialEq, Eq, Serialize, Deserialize)]
+#[derive(Debug, Clone, Copy, PartialEq, Eq, Serialize, Deserialize, Default)]
 pub enum ShadowLiftMode {
     /// Fixed lift value
     Fixed,
 
     /// Percentile-based adaptive lift (e.g., lift 1st percentile to target)
+    #[default]
     Percentile,
 
     /// No shadow lift
@@ -373,33 +378,3 @@ impl Default for ToneCurveParams {
         }
     }
 }
-
-impl Default for OutputFormat {
-    fn default() -> Self {
-        Self::Tiff16
-    }
-}
-
-impl Default for BitDepthPolicy {
-    fn default() -> Self {
-        Self::MatchInput
-    }
-}
-
-impl Default for BaseSamplingMode {
-    fn default() -> Self {
-        Self::Median
-    }
-}
-
-impl Default for InversionMode {
-    fn default() -> Self {
-        Self::Linear
-    }
-}
-
-impl Default for ShadowLiftMode {
-    fn default() -> Self {
-        Self::Percentile
-    }
-}

crates/invers-core/src/testing.rs

@@ -652,7 +652,7 @@ pub fn run_parameter_grid_search_parallel<P: AsRef<Path>>(
 
                     // Progress reporting
                     let count = completed.fetch_add(1, Ordering::Relaxed) + 1;
-                    if count % 10 == 0 || count == total_combinations {
+                    if count.is_multiple_of(10) || count == total_combinations {
                         eprintln!(
                             "[PARALLEL GRID SEARCH] Progress: {}/{}",
                             count, total_combinations

crates/invers-gui/src/main.rs

@@ -556,10 +556,10 @@ impl InversApp {
 
         for dy in 0..region_size {
             for dx in 0..region_size {
-                let sample_x = (x as i32 + dx as i32 - half_size as i32)
-                    .clamp(0, orig_image.width as i32 - 1) as u32;
-                let sample_y = (y as i32 + dy as i32 - half_size as i32)
-                    .clamp(0, orig_image.height as i32 - 1) as u32;
+                let sample_x =
+                    (x as i32 + dx - half_size).clamp(0, orig_image.width as i32 - 1) as u32;
+                let sample_y =
+                    (y as i32 + dy - half_size).clamp(0, orig_image.height as i32 - 1) as u32;
 
                 let idx = ((sample_y * orig_image.width + sample_x) * 3) as usize;
                 if idx + 2 < orig_image.data.len() {
@@ -627,10 +627,10 @@ impl InversApp {
 
         for dy in 0..region_size {
             for dx in 0..region_size {
-                let sample_x = (x as i32 + dx as i32 - half_size as i32)
-                    .clamp(0, orig_image.width as i32 - 1) as u32;
-                let sample_y = (y as i32 + dy as i32 - half_size as i32)
-                    .clamp(0, orig_image.height as i32 - 1) as u32;
+                let sample_x =
+                    (x as i32 + dx - half_size).clamp(0, orig_image.width as i32 - 1) as u32;
+                let sample_y =
+                    (y as i32 + dy - half_size).clamp(0, orig_image.height as i32 - 1) as u32;
 
                 let idx = ((sample_y * orig_image.width + sample_x) * 3) as usize;
                 if idx + 2 < orig_image.data.len() {
@@ -944,7 +944,7 @@ impl InversApp {
                     match self.process_original_for_export() {
                         Ok(processed) => {
                             let output_path = determine_output_path(
-                                &loaded_path,
+                                loaded_path,
                                 &Some(PathBuf::from(".")),
                                 match self.output_format {
                                     OutputFormat::Tiff16 => "tiff16",